-
- Downloads
There was an error fetching the commit references. Please try again later.
Omit trailing slash when proxying pre-authorized routes with no suffix
In gitlab-org/gitlab!56731, we pulled in the upstream reverse proxy code to rebase a suffix onto a URL (e.g. `/api/v4/uploads` -> `/api/v4/uploads/authorize`). In the case of `info/refs`, `git-upload-pack`, etc. no suffix is added for the authorization endpoint. The changes in that merge request would cause Workhorse to append a trailing slash when proxying the request to Rails. However, in gitlab-org/gitlab#330787, this broke Geo maintenance mode since the middleware did not strip the trailing slash. To fix this, we restore the behavior and omit the trailing slash if no pre-authorize suffix is provided. The absence or present of a trailing slash usually does not cause a material difference, but we might as well preserve the format of the original request. Changelog: fixed
parent
29c0e30f
No related branches found
No related tags found
Showing