Skip to content
Snippets Groups Projects
Commit 79c0ca78 authored by Auto-quarantining bot's avatar Auto-quarantining bot
Browse files

Quarantine a flaky test

The `` Gitlab::SlashCommands::Deploy self.match with ReDoS attempts has smaller than linear execution time growth with a malformed "to" ``
test matches one of the following conditions:
1. has either ~"flakiness::1" or ~"flakiness::2" label set, which means the number of reported failures
is at or above 95 percentile, indicating unusually high failure count.

2. has ~"severity::1" label set, which means the number of reported failures
[spiked and exceeded its daily threshold](https://gitlab.com/gitlab-org/ruby/gems/gitlab_quality-test_tooling/-/blob/c9bc10536b1f8d2d4a03c3e0b6099a40fe67ad26/lib/gitlab_quality/test_tooling/report/concerns/issue_reports.rb#L51).

This MR quarantines the test. This is a discussion starting point to let the
responsible group know about the flakiness so that they can take action:

- accept the merge request and schedule the associated issue to improve the test
- close the merge request in favor of another merge request to delete the test

Please follow the
[Flaky tests management process](https://handbook.gitlab.com/handbook/engineering/infrastructure/engineering-productivity/flaky-tests-management-and-processes/#flaky-tests-management-process)
to help us increase `master` stability.

Please let us know your feedback in the
[Engineering Productivity issue tracker](https://gitlab.com/gitlab-org/quality/engineering-productivity/team/-/issues).

Related to #469617.

This change was generated by
[gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper)
using the Keeps::QuarantineFlakyTests keep.

To provide feedback on your experience with `gitlab-housekeeper` please create an issue with the
label ~"GitLab Housekeeper" and consider pinging the author of this keep.

Changelog: other
parent 36d94f59
No related branches found
No related tags found
2 merge requests!170053Security patch upgrade alert: Only expose to admins 17-4,!166811Quarantine a flaky test
......@@ -169,7 +169,8 @@ def duration_for(&block)
Time.zone.now - start
end
it 'has smaller than linear execution time growth with a malformed "to"', :aggregate_failures do
it 'has smaller than linear execution time growth with a malformed "to"', :aggregate_failures,
quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/469617' do
expect do
Timeout.timeout(3.seconds) do
sample1 = duration_for { described_class.match("deploy abc t" + ("o" * 100000) + "X") }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment