Merge branch '513855-fix-flaky-e2e-deprecated-unregister-runner-test' into 'master'

Refresh the page after unregistering a runner

See merge request !181224



Merged-by: Dan Davison <ddavison@gitlab.com>
Approved-by: Joy Roodnick <jroodnick@gitlab.com>
Approved-by: Dan Davison <ddavison@gitlab.com>
Reviewed-by: Dan Davison <ddavison@gitlab.com>
Co-authored-by: Rémy Coutable <remy@rymai.me>

qa/qa/page/group/runners/index.rb

@@ -53,7 +53,9 @@ def has_runner_with_expected_tags?(runner)
           end
 
           def has_no_runner?(runner)
-            has_no_element?("runner-row-#{runner.id}")
+            retry_until(reload: true, sleep_interval: 2, max_attempts: 6, message: "Retry for runner removal") do
+              has_no_element?("runner-row-#{runner.id}")
+            end
           end
 
           def go_to_runner_managers_page(runner)

qa/qa/specs/features/browser_ui/4_verify/runner/deprecated_unregister_runner_spec.rb

@@ -28,8 +28,7 @@ module QA
         runner.unregister!
 
         Page::Group::Runners::Index.perform do |group_runners|
-          group_runners.refresh
-          expect { group_runners.has_no_runner?(runner) }.to eventually_be(true).within(sleep_interval: 2)
+          expect(group_runners.has_no_runner?(runner)).to be(true)
         end
       end
     end