-
- Downloads
Fix deploy keys breaking protected branch dropdown in FIPS mode
In FIPS mode, if a deploy key were present, clicking on the "Allowed to push" dropdown would fail with a "Failed to load groups, users and deploy keys" message. This occurred because the JavaScript attempted to use the `fingerprint` attribute of the key. However, on a FIPS system, the MD5 fingerprint is not available, and the `null` value breaks the dropdown. To fix this, we use the `fingerprint_sha256` attribute instead. This commit also puts the SHA256 fingerprint first in the HTML views to avoid confusion. Relates to #364562 Changelog: fixed
parent
59a796ba
No related branches found
No related tags found
Showing
- app/assets/javascripts/admin/deploy_keys/components/table.vue 19 additions, 3 deletions...assets/javascripts/admin/deploy_keys/components/table.vue
- app/assets/javascripts/deploy_keys/components/key.vue 14 additions, 4 deletionsapp/assets/javascripts/deploy_keys/components/key.vue
- app/assets/javascripts/projects/settings/access_dropdown.js 3 additions, 1 deletionapp/assets/javascripts/projects/settings/access_dropdown.js
- app/assets/javascripts/projects/settings/components/access_dropdown.vue 4 additions, 2 deletions...ascripts/projects/settings/components/access_dropdown.vue
- app/views/shared/deploy_keys/_form.html.haml 8 additions, 3 deletionsapp/views/shared/deploy_keys/_form.html.haml
- locale/gitlab.pot 4 additions, 1 deletionlocale/gitlab.pot
- spec/factories/keys.rb 6 additions, 0 deletionsspec/factories/keys.rb
- spec/features/projects/deploy_keys_spec.rb 21 additions, 5 deletionsspec/features/projects/deploy_keys_spec.rb
- spec/frontend/admin/deploy_keys/components/table_spec.js 21 additions, 8 deletionsspec/frontend/admin/deploy_keys/components/table_spec.js
- spec/frontend/fixtures/api_deploy_keys.rb 1 addition, 0 deletionsspec/frontend/fixtures/api_deploy_keys.rb
- spec/frontend/projects/settings/components/new_access_dropdown_spec.js 18 additions, 5 deletions.../projects/settings/components/new_access_dropdown_spec.js
-
mentioned in merge request kubitus-project/kubitus-installer!1252 (merged)
Please register or sign in to comment