Merge branch 'force-notification-to-saml-email-ee' into 'master'

Force notifications to SAML email address for dedicated users

See merge request gitlab-org/gitlab-ee!9712

app/views/profiles/_email_settings.html.haml

+- form = local_assigns.fetch(:form)
+- readonly = @user.read_only_attribute?(:email)
+- email_change_disabled = local_assigns.fetch(:email_change_disabled, nil)
+- read_only_help_text = readonly ? s_("Profiles|Your email address was automatically set based on your %{provider_label} account") % { provider_label: attribute_provider_label(:email) } : user_email_help_text(@user)
+- help_text = email_change_disabled ? s_("Your account uses dedicated credentials for the \"%{group_name}\" group and can only be updated through SSO.") % { group_name: @user.managing_group.name } : read_only_help_text
+
+= form.text_field :email, required: true, class: 'input-lg', value: (@user.email unless @user.temp_oauth_email?), help: help_text.html_safe, readonly: readonly || email_change_disabled
+= form.select :public_email, options_for_select(@user.all_emails, selected: @user.public_email),
+  { help: s_("Profiles|This email will be displayed on your public profile"), include_blank: s_("Profiles|Do not show on profile") },
+  control_class: 'select2 input-lg', disabled: email_change_disabled
+- commit_email_link_url = help_page_path('user/profile/index', anchor: 'commit-email', target: '_blank')
+- commit_email_link_start = '<a href="%{url}">'.html_safe % { url: commit_email_link_url }
+- commit_email_docs_link = s_('Profiles|This email will be used for web based operations, such as edits and merges. %{commit_email_link_start}Learn more%{commit_email_link_end}').html_safe % { commit_email_link_start: commit_email_link_start, commit_email_link_end: '</a>'.html_safe }
+= form.select :commit_email, options_for_select(commit_email_select_options(@user), selected: selected_commit_email(@user)),
+  { help: commit_email_docs_link },
+  control_class: 'select2 input-lg', disabled: email_change_disabled

app/views/profiles/notifications/_email_settings.html.haml

+- form = local_assigns.fetch(:form)
+.form-group
+  = form.label :notification_email, class: "label-bold"
+  = form.select :notification_email, @user.all_emails, { include_blank: false }, class: "select2", disabled: local_assigns.fetch(:email_change_disabled, nil)
+  .help-block
+    = local_assigns.fetch(:help_text, nil)

app/views/profiles/notifications/show.html.haml

@@ -22,9 +22,7 @@
         Global notification settings
 
       = form_for @user, url: profile_notifications_path, method: :put, html: { class: 'update-notifications prepend-top-default' } do |f|
-        .form-group
-          = f.label :notification_email, class: "label-bold"
-          = f.select :notification_email, @user.all_emails, { include_blank: false }, class: "select2"
+        = render_if_exists 'profiles/notifications/email_settings', form: f
 
       = label_tag :global_notification_level, "Global notification level", class: "label-bold"
       %br

app/views/profiles/show.html.haml

@@ -83,18 +83,7 @@
           = f.text_field :name, label: 'Full name', required: true, title: s_("Profiles|Using emojis in names seems fun, but please try to set a status message instead"), wrapper: { class: 'col-md-9 qa-full-name' }, help: s_("Profiles|Enter your name, so people you know can recognize you")
         = f.text_field :id, readonly: true, label: 'User ID', wrapper: { class: 'col-md-3' }
 
-      - if @user.read_only_attribute?(:email)
-        = f.text_field :email, required: true, class: 'input-lg', readonly: true, help: s_("Profiles|Your email address was automatically set based on your %{provider_label} account") % { provider_label: attribute_provider_label(:email) }
-      - else
-        = f.text_field :email, required: true, class: 'input-lg', value: (@user.email unless @user.temp_oauth_email?),
-          help: user_email_help_text(@user)
-      = f.select :public_email, options_for_select(@user.all_emails, selected: @user.public_email),
-        { help: s_("Profiles|This email will be displayed on your public profile"), include_blank: s_("Profiles|Do not show on profile") },
-        control_class: 'select2 input-lg'
-      - commit_email_docs_link = link_to s_('Profiles|Learn more'), help_page_path('user/profile/index', anchor: 'commit-email', target: '_blank')
-      = f.select :commit_email, options_for_select(commit_email_select_options(@user), selected: selected_commit_email(@user)),
-        { help: s_("Profiles|This email will be used for web based operations, such as edits and merges. %{learn_more}").html_safe % { learn_more: commit_email_docs_link } },
-        control_class: 'select2 input-lg'
+      = render_if_exists 'profiles/email_settings', form: f
       = f.text_field :skype, class: 'input-md', placeholder: s_("Profiles|username")
       = f.text_field :linkedin, class: 'input-md', help: s_("Profiles|Your LinkedIn profile name from linkedin.com/in/profilename")
       = f.text_field :twitter, class: 'input-md', placeholder: s_("Profiles|@username")

ee/app/models/saml_provider.rb

 # frozen_string_literal: true
 
 class SamlProvider < ActiveRecord::Base
+  USER_ATTRIBUTES_LOCKED_FOR_MANAGED_ACCOUNTS = %i(email public_email commit_email notification_email).freeze
+
   belongs_to :group
   has_many :identities
 

ee/app/services/ee/users/update_service.rb

@@ -3,6 +3,7 @@
 module EE
   module Users
     module UpdateService
+      extend ::Gitlab::Utils::Override
       include EE::Audit::Changes # rubocop: disable Cop/InjectEnterpriseEditionModule
 
       private
@@ -19,6 +20,12 @@ def notify_success(user_exists)
       def model
         @user
       end
+
+      override :assign_attributes
+      def assign_attributes
+        params.reject! { |key, _| SamlProvider::USER_ATTRIBUTES_LOCKED_FOR_MANAGED_ACCOUNTS.include?(key.to_sym) } if model.group_managed_account?
+        super
+      end
     end
   end
 end

ee/app/views/profiles/_email_settings.html.haml

+- group_managed_account = @user.group_managed_account?
+
+= render_ce 'profiles/email_settings', form: form, email_change_disabled: group_managed_account

ee/app/views/profiles/notifications/_email_settings.html.haml

+- group_managed_account = @user.group_managed_account?
+- help_text = group_managed_account ? s_("Your account uses dedicated credentials for the \"%{group_name}\" group and can only be updated through SSO.").html_safe % { group_name: @user.managing_group.name } : nil
+= render_ce 'profiles/notifications/email_settings', email_change_disabled: group_managed_account, help_text: help_text, form: form
+

ee/changelogs/unreleased/force-notification-to-saml-email-ee.yml

+---
+title: Block possibility to change email for users with group managed account
+merge_request: 9712
+author:
+type: added

ee/spec/services/users/update_service_spec.rb

+# frozen_string_literal: true
+require 'spec_helper'
+
+describe Users::UpdateService do
+  let(:user) { create(:user) }
+
+  describe '#execute' do
+    it 'does not update email if an user has group managed account' do
+      allow(user).to receive(:group_managed_account?).and_return(true)
+
+      expect do
+        update_user(user, { email: 'foreign@email' })
+      end.not_to change { user.reload.email }
+    end
+
+    it 'does not update commit email if an user has group managed account' do
+      allow(user).to receive(:group_managed_account?).and_return(true)
+
+      expect do
+        update_user(user, { commit_email: 'foreign@email' })
+      end.not_to change { user.reload.commit_email }
+    end
+
+    it 'does not update public if an user has group managed account' do
+      allow(user).to receive(:group_managed_account?).and_return(true)
+
+      expect do
+        update_user(user, { public_email: 'foreign@email' })
+      end.not_to change { user.reload.public_email }
+    end
+
+    it 'does not update public if an user has group managed account' do
+      allow(user).to receive(:group_managed_account?).and_return(true)
+
+      expect do
+        update_user(user, { notification_email: 'foreign@email' })
+      end.not_to change { user.reload.notification_email }
+    end
+
+    def update_user(user, opts)
+      described_class.new(user, opts.merge(user: user)).execute!
+    end
+  end
+end

locale/gitlab.pot

@@ -7788,7 +7788,7 @@ msgstr ""
 msgid "Profiles|This email will be displayed on your public profile"
 msgstr ""
 
-msgid "Profiles|This email will be used for web based operations, such as edits and merges. %{learn_more}"
+msgid "Profiles|This email will be used for web based operations, such as edits and merges. %{commit_email_link_start}Learn more%{commit_email_link_end}"
 msgstr ""
 
 msgid "Profiles|This emoji and message will appear on your profile and throughout the interface."
@@ -11732,6 +11732,9 @@ msgstr ""
 msgid "Your U2F device was registered!"
 msgstr ""
 
+msgid "Your account uses dedicated credentials for the \"%{group_name}\" group and can only be updated through SSO."
+msgstr ""
+
 msgid "Your applications (%{size})"
 msgstr ""