Skip to content
Snippets Groups Projects
Verified Commit 4c7a55e2 authored by Auto-quarantining bot's avatar Auto-quarantining bot Committed by GitLab
Browse files

Mark 20240807160655 as obsolete

This migration marks the 20240807160655 ReindexAllIssuesFromDatabase Advanced search migration as obsolete.

[Search for references to `reindex_all_issues_from_database` in code](https://gitlab.com/search?project_id=278964&scope=blobs&search=reindex_all_issues_from_database&regex=false))

At the moment, the `gitlab-housekeeper` is not always capable of removing all references so
you must check the diff and pipeline failures to confirm if there are any issues.
It is the responsibility of the assignee (picked from ~"group::global search") to push those changes to this branch.

[Read more](https://docs.gitlab.com/ee/development/search/advanced_search_migration_styleguide.html#cleaning-up-advanced-search-migrations)
about the process for marking Advanced search migrations as obsolete.

All Advanced search migrations must have had at least one
[required stop](https : // docs.gitlab.com / ee / development / database / required_stops.html)
to process the migration. Therefore we mark any Advanced search migrations added before the
last required stop as obsolete.

This change was generated by
[gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper)
using the Keeps::MarkOldAdvancedSearchMigrationsAsObsolete keep.

To provide feedback on your experience with `gitlab-housekeeper` please create an issue with the
label ~"GitLab Housekeeper" and consider pinging the author of this keep.

Changelog: other
EE: true
parent e3a38662
No related branches found
No related tags found
3 merge requests!181325Fix ambiguous `created_at` in project.rb,!179611Draft: Rebase CR approach for zoekt assignments,!178352Mark 20240807160655 as obsolete
......@@ -5,6 +5,6 @@ description: Reindexes every issue from the database to ensure the correct state
group: group::global search
milestone: '17.4'
introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/162024
obsolete: false
marked_obsolete_by_url:
marked_obsolete_in_milestone:
obsolete: true
marked_obsolete_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/178352
marked_obsolete_in_milestone: '17.9'
......@@ -25,3 +25,5 @@ def documents_after_current_id
end
# rubocop:enable CodeReuse/ActiveRecord
end
ReindexAllIssuesFromDatabase.prepend ::Elastic::MigrationObsolete
......@@ -6,28 +6,5 @@
# See https://docs.gitlab.com/ee/development/testing_guide/best_practices.html#elasticsearch-specs
# for more information on how to write search migration specs for GitLab.
RSpec.describe ReindexAllIssuesFromDatabase, feature_category: :global_search do
let(:version) { 20240807160655 }
describe 'migration', :elastic do
it_behaves_like 'migration reindexes all data' do
let(:objects) { create_list(:issue, 3) }
let(:expected_throttle_delay) { 1.minute }
let(:expected_batch_size) { 50_000 }
end
end
describe '#documents_after_current_id' do
let(:migration) { described_class.new(version) }
let_it_be(:project) { create(:project, :public) }
let_it_be(:issue) { create(:issue, project: project) }
let_it_be(:issue_epic_type) { create(:issue, :epic) }
let_it_be(:issue_task_type) { create(:issue, :task) }
let_it_be(:work_item) { create(:work_item, :epic_with_legacy_epic, :group_level) }
let_it_be(:non_group_work_item) { create(:work_item) }
it 'only indexes project-level work_item_type issues' do
expected_ids = [issue.id, issue_task_type.id, non_group_work_item.id]
expect(migration.documents_after_current_id.pluck(:id)).to match_array(expected_ids)
end
end
it_behaves_like 'a deprecated Advanced Search migration', 20240807160655
end
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment