Skip to content
Snippets Groups Projects
Verified Commit 473b59a4 authored by Abdul Wadood's avatar Abdul Wadood :palm_tree:
Browse files

Fix Lint/RedundantCopDisableDirective offenses

As we want to enable this cop after fixing all the offenses.
parent 6ecfb89f
No related branches found
No related tags found
2 merge requests!171309Draft: Fetch issues / MRs / epics count in the sidebar with GraphQL,!171068Fix Lint/RedundantCopDisableDirective offenses
Showing
with 32 additions and 127 deletions
......@@ -234,7 +234,6 @@ Layout/LineLength:
- 'app/models/concerns/analytics/cycle_analytics/stage_event_model.rb'
- 'app/models/concerns/avatarable.rb'
- 'app/models/concerns/bulk_insert_safe.rb'
- 'app/models/concerns/bulk_users_by_email_load.rb'
- 'app/models/concerns/cache_markdown_field.rb'
- 'app/models/concerns/cacheable_attributes.rb'
- 'app/models/concerns/cascading_namespace_setting_attribute.rb'
......@@ -263,7 +262,6 @@ Layout/LineLength:
- 'app/models/concerns/sortable.rb'
- 'app/models/concerns/subscribable.rb'
- 'app/models/concerns/token_authenticatable_strategies/base.rb'
- 'app/models/concerns/token_authenticatable_strategies/encrypted.rb'
- 'app/models/concerns/update_highest_role.rb'
- 'app/models/concerns/update_project_statistics.rb'
- 'app/models/concerns/x509_serial_number_attribute.rb'
......@@ -588,6 +586,19 @@ Layout/LineLength:
- 'danger/feature_flag/Dangerfile'
- 'danger/roulette/Dangerfile'
- 'danger/vue_shared_documentation/Dangerfile'
- 'db/post_migrate/20240123040846_swap_columns_for_system_note_metadata_id.rb'
- 'db/post_migrate/20240131000657_prepare_async_index_for_p_ci_builds_part2.rb'
- 'db/post_migrate/20240206050011_sync_index_for_p_ci_builds_part2.rb'
- 'db/post_migrate/20240319005754_swap_columns_for_upstream_pipeline_id_between_ci_builds_and_ci_pipelines.rb'
- 'db/post_migrate/20240410070036_prepare_async_indexes_for_pipelines_id_bigint.rb'
- 'db/post_migrate/20240412000002_prepare_async_index_for_builds_part5.rb'
- 'db/post_migrate/20240421011547_sync_index_for_pipelines_id_bigint_related.rb'
- 'db/post_migrate/20240422070036_swap_ci_pipelines_pk_with_bigint_p_ci_builds_p_ci_stages.rb'
- 'db/post_migrate/20240423035245_sync_index_for_pipelines_id_bigint_part5.rb'
- 'db/post_migrate/20240423235307_swap_columns_for_p_ci_builds_project_id.rb'
- 'db/post_migrate/20240424103758_prepare_async_index_for_builds_part6.rb'
- 'db/post_migrate/20240430015450_sync_index_for_builds_user_id_bigint.rb'
- 'db/post_migrate/20240430015514_swap_columns_for_p_ci_builds_user_id.rb'
- 'ee/app/controllers/concerns/audit_events/date_range.rb'
- 'ee/app/controllers/concerns/credentials_inventory_actions.rb'
- 'ee/app/controllers/concerns/ee/issuable_collections.rb'
......@@ -1030,6 +1041,7 @@ Layout/LineLength:
- 'ee/lib/ee/gitlab/auth/ldap/sync/group.rb'
- 'ee/lib/ee/gitlab/auth/ldap/sync/users.rb'
- 'ee/lib/ee/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb'
- 'ee/lib/ee/gitlab/background_migration/create_compliance_standards_adherence.rb'
- 'ee/lib/ee/gitlab/background_migration/create_security_setting.rb'
- 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb'
- 'ee/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids.rb'
......@@ -1093,7 +1105,6 @@ Layout/LineLength:
- 'ee/lib/gitlab/insights/serializers/chartjs/bar_serializer.rb'
- 'ee/lib/gitlab/insights/serializers/chartjs/multi_series_serializer.rb'
- 'ee/lib/gitlab/insights/validators/params_validator.rb'
- 'ee/lib/gitlab/manual_quarterly_co_term_banner.rb'
- 'ee/lib/gitlab/sitemaps/generator.rb'
- 'ee/lib/gitlab/status_page/storage/s3_client.rb'
- 'ee/lib/gitlab/usage/metrics/instrumentations/approval_project_rules_with_user_metric.rb'
......@@ -1337,7 +1348,6 @@ Layout/LineLength:
- 'ee/spec/helpers/ee/access_tokens_helper_spec.rb'
- 'ee/spec/helpers/ee/application_settings_helper_spec.rb'
- 'ee/spec/helpers/ee/branches_helper_spec.rb'
- 'ee/spec/helpers/ee/ci/pipelines_helper_spec.rb'
- 'ee/spec/helpers/ee/feature_flags_helper_spec.rb'
- 'ee/spec/helpers/ee/gitlab_routing_helper_spec.rb'
- 'ee/spec/helpers/ee/groups/group_members_helper_spec.rb'
......@@ -2043,7 +2053,6 @@ Layout/LineLength:
- 'ee/spec/support/shared_examples/services/vulnerabilities/calls_vulnerability_statistics_utility_services_in_order.rb'
- 'ee/spec/support/shared_examples/views/subscription_shared_examples.rb'
- 'ee/spec/tasks/geo_rake_spec.rb'
- 'ee/spec/tasks/gitlab/geo_rake_spec.rb'
- 'ee/spec/validators/json_schema_validator_spec.rb'
- 'ee/spec/views/admin/application_settings/_elasticsearch_form.html.haml_spec.rb'
- 'ee/spec/views/admin/application_settings/general.html.haml_spec.rb'
......@@ -2245,7 +2254,9 @@ Layout/LineLength:
- 'lib/gitlab/auth/user_access_denied_reason.rb'
- 'lib/gitlab/background_migration/backfill_issue_search_data.rb'
- 'lib/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb'
- 'lib/gitlab/background_migration/backfill_project_statistics_storage_size_without_pipeline_artifacts_size_job.rb'
- 'lib/gitlab/background_migration/backfill_snippet_repositories.rb'
- 'lib/gitlab/background_migration/backfill_workspace_personal_access_token.rb'
- 'lib/gitlab/background_migration/batching_strategies/backfill_project_namespace_per_group_batching_strategy.rb'
- 'lib/gitlab/background_migration/create_security_setting.rb'
- 'lib/gitlab/background_migration/fix_projects_without_project_feature.rb'
......@@ -2256,6 +2267,8 @@ Layout/LineLength:
- 'lib/gitlab/background_migration/migrate_job_artifact_registry_to_ssf.rb'
- 'lib/gitlab/background_migration/migrate_requirements_to_work_items.rb'
- 'lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces.rb'
- 'lib/gitlab/background_migration/update_workspaces_config_version.rb'
- 'lib/gitlab/background_migration/update_workspaces_config_version3.rb'
- 'lib/gitlab/bullet/exclusions.rb'
- 'lib/gitlab/cache/helpers.rb'
- 'lib/gitlab/changelog/config.rb'
......@@ -3656,7 +3669,6 @@ Layout/LineLength:
- 'spec/models/concerns/resolvable_note_spec.rb'
- 'spec/models/concerns/routable_spec.rb'
- 'spec/models/concerns/sortable_spec.rb'
- 'spec/models/concerns/token_authenticatable_spec.rb'
- 'spec/models/concerns/token_authenticatable_strategies/encryption_helper_spec.rb'
- 'spec/models/concerns/x509_serial_number_attribute_spec.rb'
- 'spec/models/container_repository_spec.rb'
......
......@@ -13,50 +13,13 @@ Lint/RedundantCopDisableDirective:
- 'app/services/work_items/data_sync/move_service.rb'
- 'app/workers/authorized_project_update/user_refresh_over_user_range_worker.rb'
- 'config/initializers/warden.rb'
- 'db/migrate/20240701145111_add_namespace_import_users_table.rb'
- 'db/migrate/20240829163210_create_instance_integrations_table.rb'
- 'db/post_migrate/20231017064317_swap_columns_for_ci_pipeline_variables_pipeline_id_bigint.rb'
- 'db/post_migrate/20231019003052_swap_columns_for_ci_pipelines_pipeline_id_bigint_v2.rb'
- 'db/post_migrate/20231019084731_swap_columns_for_ci_stages_pipeline_id_bigint_v2.rb'
- 'db/post_migrate/20231024025629_cleanup_ci_pipeline_chat_data_pipeline_id_bigint.rb'
- 'db/post_migrate/20231024080150_cleanup_ci_sources_pipelines_pipeline_id_bigint.rb'
- 'db/post_migrate/20231025031337_cleanup_ci_pipeline_messages_pipeline_id_bigint.rb'
- 'db/post_migrate/20231031204841_requeue_backfill_has_remediations_of_vulnerability_reads.rb'
- 'db/post_migrate/20231201204712_requeue2_backfill_has_remediations_of_vulnerability_reads.rb'
- 'db/post_migrate/20240123040846_swap_columns_for_system_note_metadata_id.rb'
- 'db/post_migrate/20240131000657_prepare_async_index_for_p_ci_builds_part2.rb'
- 'db/post_migrate/20240206050011_sync_index_for_p_ci_builds_part2.rb'
- 'db/post_migrate/20240319005754_swap_columns_for_upstream_pipeline_id_between_ci_builds_and_ci_pipelines.rb'
- 'db/post_migrate/20240410070036_prepare_async_indexes_for_pipelines_id_bigint.rb'
- 'db/post_migrate/20240412000002_prepare_async_index_for_builds_part5.rb'
- 'db/post_migrate/20240421011547_sync_index_for_pipelines_id_bigint_related.rb'
- 'db/post_migrate/20240422070036_swap_ci_pipelines_pk_with_bigint_p_ci_builds_p_ci_stages.rb'
- 'db/post_migrate/20240423035245_sync_index_for_pipelines_id_bigint_part5.rb'
- 'db/post_migrate/20240423235307_swap_columns_for_p_ci_builds_project_id.rb'
- 'db/post_migrate/20240424103758_prepare_async_index_for_builds_part6.rb'
- 'db/post_migrate/20240430015450_sync_index_for_builds_user_id_bigint.rb'
- 'db/post_migrate/20240430015514_swap_columns_for_p_ci_builds_user_id.rb'
- 'db/post_migrate/20240902014331_sync_fk_referencing_p_ci_pipelines.rb'
- 'db/post_migrate/20240917143249_partition_ci_build_trace_metadata3.rb'
- 'ee/app/controllers/ee/projects/settings/ci_cd_controller.rb'
- 'ee/app/services/search/zoekt/routing_service.rb'
- 'ee/app/services/security/token_revocation_service.rb'
- 'ee/db/geo/migrate/20210504143244_add_verification_to_merge_request_diff_registry.rb'
- 'ee/lib/ee/gitlab/background_migration/backfill_dismissal_reason_in_vulnerability_reads.rb'
- 'ee/lib/ee/gitlab/background_migration/backfill_missing_vulnerability_dismissal_details.rb'
- 'ee/lib/ee/gitlab/background_migration/backfill_zoekt_replicas.rb'
- 'ee/lib/ee/gitlab/background_migration/create_compliance_standards_adherence.rb'
- 'ee/lib/ee/gitlab/background_migration/create_vulnerability_links.rb'
- 'ee/lib/ee/gitlab/background_migration/migrate_vulnerabilities_feedback_to_vulnerabilities_state_transition.rb'
- 'ee/lib/ee/gitlab/background_migration/populate_denormalized_columns_for_sbom_occurrences.rb'
- 'ee/lib/ee/gitlab/background_migration/purge_stale_security_scans.rb'
- 'ee/spec/features/groups/settings/domain_verification_spec.rb'
- 'ee/spec/features/projects/mirror_spec.rb'
- 'ee/spec/lib/banzai/filter/references/iterations_cadence_reference_filter_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/backfill_missing_vulnerability_dismissal_details_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/delete_orphaned_transferred_project_approval_rules_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/populate_denormalized_columns_for_sbom_occurrences_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/purge_security_scans_with_empty_finding_data_spec.rb'
- 'ee/spec/lib/gitlab/elastic/client_spec.rb'
- 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_secure_pipelines_metric_spec.rb'
- 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_security_scans_metric_spec.rb'
......@@ -64,53 +27,7 @@ Lint/RedundantCopDisableDirective:
- 'ee/spec/views/admin/users/show.html.haml_spec.rb'
- 'lib/api/submodules.rb'
- 'lib/gitlab/auth/current_user_mode.rb'
- 'lib/gitlab/background_migration/backfill_desired_sharding_key_partition_job.rb'
- 'lib/gitlab/background_migration/backfill_epic_basic_fields_to_work_item_record.rb'
- 'lib/gitlab/background_migration/backfill_finding_id_in_vulnerabilities.rb'
- 'lib/gitlab/background_migration/backfill_imported_issue_search_data.rb'
- 'lib/gitlab/background_migration/backfill_issue_search_data.rb'
- 'lib/gitlab/background_migration/backfill_issue_search_data_namespace_id.rb'
- 'lib/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb'
- 'lib/gitlab/background_migration/backfill_missing_vulnerability_dismissal_details.rb'
- 'lib/gitlab/background_migration/backfill_nuget_normalized_version.rb'
- 'lib/gitlab/background_migration/backfill_or_drop_ci_pipeline_on_project_id.rb'
- 'lib/gitlab/background_migration/backfill_project_statistics_storage_size_without_pipeline_artifacts_size_job.rb'
- 'lib/gitlab/background_migration/backfill_workspace_personal_access_token.rb'
- 'lib/gitlab/background_migration/batching_strategies/loose_index_scan_batching_strategy.rb'
- 'lib/gitlab/background_migration/convert_credit_card_validation_data_to_hashes.rb'
- 'lib/gitlab/background_migration/create_compliance_standards_adherence.rb'
- 'lib/gitlab/background_migration/create_vulnerability_links.rb'
- 'lib/gitlab/background_migration/delete_invalid_epic_issues.rb'
- 'lib/gitlab/background_migration/delete_orphans_approval_merge_request_rules2.rb'
- 'lib/gitlab/background_migration/delete_orphans_approval_project_rules2.rb'
- 'lib/gitlab/background_migration/destroy_invalid_group_members.rb'
- 'lib/gitlab/background_migration/destroy_invalid_members.rb'
- 'lib/gitlab/background_migration/destroy_invalid_project_members.rb'
- 'lib/gitlab/background_migration/fix_first_mentioned_in_commit_at.rb'
- 'lib/gitlab/background_migration/mailers/unconfirm_mailer.rb'
- 'lib/gitlab/background_migration/migrate_approver_to_approval_rules.rb'
- 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_check_progress.rb'
- 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch.rb'
- 'lib/gitlab/background_migration/migrate_job_artifact_registry_to_ssf.rb'
- 'lib/gitlab/background_migration/migrate_shared_vulnerability_scanners.rb'
- 'lib/gitlab/background_migration/migrate_vulnerabilities_feedback_to_vulnerabilities_state_transition.rb'
- 'lib/gitlab/background_migration/populate_denormalized_columns_for_sbom_occurrences.rb'
- 'lib/gitlab/background_migration/populate_latest_pipeline_ids.rb'
- 'lib/gitlab/background_migration/populate_vulnerability_dismissal_fields.rb'
- 'lib/gitlab/background_migration/purge_stale_security_scans.rb'
- 'lib/gitlab/background_migration/resolve_vulnerabilities_for_removed_analyzers.rb'
- 'lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url.rb'
- 'lib/gitlab/background_migration/update_workspaces_config_version.rb'
- 'lib/gitlab/background_migration/update_workspaces_config_version3.rb'
- 'lib/gitlab/cleanup/personal_access_tokens.rb'
- 'lib/gitlab/database/consistency_checker.rb'
- 'lib/gitlab/database/gitlab_schema.rb'
- 'lib/gitlab/database/migration.rb'
- 'lib/gitlab/database/migrations/milestone_mixin.rb'
- 'lib/gitlab/database/migrations/observation.rb'
- 'lib/gitlab/database/migrations/observers/query_log.rb'
- 'lib/gitlab/database/migrations/runner_backoff/migration_helpers.rb'
- 'lib/gitlab/database/migrations/squasher.rb'
- 'lib/gitlab/lfs_token.rb'
- 'lib/gitlab/popen/runner.rb'
- 'qa/qa/resource/user_runners.rb'
......@@ -119,16 +36,6 @@ Lint/RedundantCopDisableDirective:
- 'spec/components/previews/pajamas/banner_component_preview.rb'
- 'spec/features/groups/participants_autocomplete_spec.rb'
- 'spec/features/merge_request/user_edits_mr_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_finding_id_in_vulnerabilities_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_missing_ci_cd_settings_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_root_storage_statistics_fork_storage_sizes_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_uuid_conversion_column_in_vulnerability_occurrences_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_vulnerability_reads_cluster_agent_spec.rb'
- 'spec/lib/gitlab/background_migration/batching_strategies/backfill_project_statistics_with_container_registry_size_batching_strategy_spec.rb'
- 'spec/lib/gitlab/background_migration/convert_credit_card_validation_data_to_hashes_spec.rb'
- 'spec/lib/gitlab/background_migration/drop_vulnerabilities_without_finding_id_spec.rb'
- 'spec/lib/gitlab/background_migration/populate_vulnerability_dismissal_fields_spec.rb'
- 'spec/lib/gitlab/background_migration/resolve_vulnerabilities_for_removed_analyzers_spec.rb'
- 'spec/lib/gitlab/doorkeeper_secret_storing/secret/pbkdf2_sha512_spec.rb'
- 'spec/lib/gitlab/doorkeeper_secret_storing/token/pbkdf2_sha512_spec.rb'
- 'spec/lib/gitlab/merge_requests/message_generator_spec.rb'
......
......@@ -4,7 +4,7 @@ class AddNamespaceImportUsersTable < Gitlab::Database::Migration[2.2]
milestone '17.2'
def up
create_table :namespace_import_users do |t| # rubocop:disable Migration/EnsureFactoryForTable -- False Positive
create_table :namespace_import_users do |t|
t.bigint :user_id, null: false
t.bigint :namespace_id, null: false
......
......@@ -3,7 +3,6 @@
class CreateInstanceIntegrationsTable < Gitlab::Database::Migration[2.2]
milestone '17.4'
# rubocop:disable Migration/EnsureFactoryForTable -- False Positive
def up
create_table :instance_integrations, id: :bigserial do |t|
t.timestamps_with_timezone null: false
......@@ -34,7 +33,6 @@ def up
t.binary :encrypted_properties_iv
end
end
# rubocop:enable Migration/EnsureFactoryForTable -- False Positive
def down
drop_table :instance_integrations, if_exists: true
......
......@@ -15,7 +15,6 @@ def down
private
def swap
# rubocop:disable Migration/WithLockRetriesDisallowedMethod
with_lock_retries(raise_on_exhaustion: true) do
lock_tables(:ci_pipelines, :ci_pipeline_variables)
......@@ -41,6 +40,5 @@ def swap
:index_ci_pipeline_variables_on_pipeline_id_bigint_and_key
)
end
# rubocop:enable Migration/WithLockRetriesDisallowedMethod
end
end
......@@ -38,7 +38,6 @@ def column_type_of?(type)
end
def swap
# rubocop:disable Migration/WithLockRetriesDisallowedMethod
with_lock_retries(raise_on_exhaustion: true) do
# Lock the tables involved.
lock_tables(TABLE_NAME)
......@@ -55,6 +54,5 @@ def swap
# Swap index
swap_indexes(TABLE_NAME, INDEX_NAME, BIGINT_INDEX_NAME)
end
# rubocop:enable Migration/WithLockRetriesDisallowedMethod
end
end
......@@ -48,7 +48,6 @@ def column_type_of?(type)
end
def swap
# rubocop:disable Migration/WithLockRetriesDisallowedMethod
with_lock_retries(raise_on_exhaustion: true) do
# Lock the tables involved.
lock_tables(:ci_pipelines, :ci_stages)
......@@ -67,6 +66,5 @@ def swap
swap_indexes(TABLE_NAME, index_name, BIGINT_INDEX_NAMES[i])
end
end
# rubocop:enable Migration/WithLockRetriesDisallowedMethod
end
end
......@@ -8,7 +8,7 @@ class CleanupCiPipelineChatDataPipelineIdBigint < Gitlab::Database::Migration[2.
def up
with_lock_retries(raise_on_exhaustion: true) do
cleanup_conversion_of_integer_to_bigint(TABLE, COLUMNS) # rubocop:disable Migration/WithLockRetriesDisallowedMethod
cleanup_conversion_of_integer_to_bigint(TABLE, COLUMNS)
end
end
......
......@@ -10,7 +10,7 @@ class CleanupCiSourcesPipelinesPipelineIdBigint < Gitlab::Database::Migration[2.
def up
with_lock_retries(raise_on_exhaustion: true) do
lock_tables(:ci_pipelines, TABLE)
cleanup_conversion_of_integer_to_bigint(TABLE, COLUMNS) # rubocop:disable Migration/WithLockRetriesDisallowedMethod
cleanup_conversion_of_integer_to_bigint(TABLE, COLUMNS)
end
end
......
......@@ -9,7 +9,7 @@ class CleanupCiPipelineMessagesPipelineIdBigint < Gitlab::Database::Migration[2.
def up
with_lock_retries(raise_on_exhaustion: true) do
lock_tables(:ci_pipelines, TABLE)
cleanup_conversion_of_integer_to_bigint(TABLE, COLUMNS) # rubocop:disable Migration/WithLockRetriesDisallowedMethod
cleanup_conversion_of_integer_to_bigint(TABLE, COLUMNS)
end
end
......
# frozen_string_literal: true
# rubocop: disable BackgroundMigration/DictionaryFile -- queued/introduced before the rule is introduced
class RequeueBackfillHasRemediationsOfVulnerabilityReads < Gitlab::Database::Migration[2.2]
milestone '16.7'
......@@ -23,4 +21,3 @@ def up; end
def down; end
end
# rubocop: enable BackgroundMigration/DictionaryFile
# frozen_string_literal: true
# rubocop: disable BackgroundMigration/DictionaryFile -- queued/introduced before the rule is introduced
class Requeue2BackfillHasRemediationsOfVulnerabilityReads < Gitlab::Database::Migration[2.2]
milestone '16.7'
......@@ -35,4 +33,3 @@ def down
end
end
end
# rubocop: enable BackgroundMigration/DictionaryFile
......@@ -73,7 +73,7 @@ def swap
# This will drop fk_2a039c40f4 ("resource_link_events" REFERENCES system_note_metadata(id) ON DELETE CASCADE)
execute "ALTER TABLE #{TABLE_NAME} DROP CONSTRAINT #{PRIMARY_KEY_CONSTRAINT_NAME} CASCADE"
rename_index TABLE_NAME, NEW_PRIMARY_KEY_INDEX_NAME, PRIMARY_KEY_INDEX_NAME
execute "ALTER TABLE #{TABLE_NAME} ADD CONSTRAINT #{PRIMARY_KEY_CONSTRAINT_NAME} PRIMARY KEY USING INDEX #{PRIMARY_KEY_INDEX_NAME}" # rubocop:disable Layout/LineLength -- for readability
execute "ALTER TABLE #{TABLE_NAME} ADD CONSTRAINT #{PRIMARY_KEY_CONSTRAINT_NAME} PRIMARY KEY USING INDEX #{PRIMARY_KEY_INDEX_NAME}"
# Rename the new FK
rename_constraint FK_SOURCE_TABLE_NAME, TEMP_FK_NAME, FK_NAME
......
......@@ -12,7 +12,7 @@ class PrepareAsyncIndexForPCiBuildsPart2 < Gitlab::Database::Migration[2.2]
[[:commit_id_convert_to_bigint, :type, :ref], "p_ci_builds_commit_id_bigint_type_ref_idx", {}],
[[:commit_id_convert_to_bigint, :artifacts_expire_at, :id],
"p_ci_builds_commit_id_bigint_artifacts_expire_at_id_idx", {
where: "type::text = 'Ci::Build'::text AND (retried = false OR retried IS NULL) AND (name::text = ANY (ARRAY['sast'::character varying::text, 'secret_detection'::character varying::text, 'dependency_scanning'::character varying::text, 'container_scanning'::character varying::text, 'dast'::character varying::text]))" # rubocop:disable Layout/LineLength -- Where clause is just too long.
where: "type::text = 'Ci::Build'::text AND (retried = false OR retried IS NULL) AND (name::text = ANY (ARRAY['sast'::character varying::text, 'secret_detection'::character varying::text, 'dependency_scanning'::character varying::text, 'container_scanning'::character varying::text, 'dast'::character varying::text]))"
}]
]
TABLE_NAME = :p_ci_builds
......
......@@ -21,7 +21,7 @@ class SyncIndexForPCiBuildsPart2 < Gitlab::Database::Migration[2.2]
name: "p_ci_builds_commit_id_bigint_artifacts_expire_at_id_idx",
columns: [:commit_id_convert_to_bigint, :artifacts_expire_at, :id],
options: {
where: "type::text = 'Ci::Build'::text AND (retried = false OR retried IS NULL) AND (name::text = ANY (ARRAY['sast'::character varying::text, 'secret_detection'::character varying::text, 'dependency_scanning'::character varying::text, 'container_scanning'::character varying::text, 'dast'::character varying::text]))" # rubocop:disable Layout/LineLength -- Where clause is just too long.
where: "type::text = 'Ci::Build'::text AND (retried = false OR retried IS NULL) AND (name::text = ANY (ARRAY['sast'::character varying::text, 'secret_detection'::character varying::text, 'dependency_scanning'::character varying::text, 'container_scanning'::character varying::text, 'dast'::character varying::text]))"
}
}
]
......
......@@ -29,7 +29,7 @@ class SwapColumnsForUpstreamPipelineIdBetweenCiBuildsAndCiPipelines < Gitlab::Da
name: :p_ci_builds_commit_id_bigint_artifacts_expire_at_id_idx,
columns: [:commit_id_convert_to_bigint, :artifacts_expire_at, :id],
options: {
where: "type::text = 'Ci::Build'::text AND (retried = false OR retried IS NULL) AND (name::text = ANY (ARRAY['sast'::character varying::text, 'secret_detection'::character varying::text, 'dependency_scanning'::character varying::text, 'container_scanning'::character varying::text, 'dast'::character varying::text]))" # rubocop:disable Layout/LineLength -- Where clause is just too long.
where: "type::text = 'Ci::Build'::text AND (retried = false OR retried IS NULL) AND (name::text = ANY (ARRAY['sast'::character varying::text, 'secret_detection'::character varying::text, 'dependency_scanning'::character varying::text, 'container_scanning'::character varying::text, 'dast'::character varying::text]))"
},
old_name: :p_ci_builds_commit_id_artifacts_expire_at_id_idx
},
......
......@@ -46,7 +46,7 @@ class PrepareAsyncIndexesForPipelinesIdBigint < Gitlab::Database::Migration[2.2]
{
name: :idx_ci_pipelines_on_user_id_and_id_and_cancelable_status_bigint,
columns: [:user_id, :id_convert_to_bigint],
options: { where: "((status)::text = ANY (ARRAY[('running'::character varying)::text, ('waiting_for_resource'::character varying)::text, ('preparing'::character varying)::text, ('pending'::character varying)::text, ('created'::character varying)::text, ('scheduled'::character varying)::text]))" } # rubocop:disable Layout/LineLength -- Just too long
options: { where: "((status)::text = ANY (ARRAY[('running'::character varying)::text, ('waiting_for_resource'::character varying)::text, ('preparing'::character varying)::text, ('pending'::character varying)::text, ('created'::character varying)::text, ('scheduled'::character varying)::text]))" }
},
{
name: :idx_ci_pipelines_on_user_id_and_user_not_verified_bigint,
......
......@@ -9,12 +9,12 @@ class PrepareAsyncIndexForBuildsPart5 < Gitlab::Database::Migration[2.2]
{
name: :p_ci_builds_project_id_bigint_name_ref_idx,
columns: [:project_id_convert_to_bigint, :name, :ref],
options: { where: "type::text = 'Ci::Build'::text AND status::text = 'success'::text AND (retried = false OR retried IS NULL)" } # rubocop:disable Layout/LineLength -- it's just too long
options: { where: "type::text = 'Ci::Build'::text AND status::text = 'success'::text AND (retried = false OR retried IS NULL)" }
},
{
name: :p_ci_builds_project_id_bigint_status_idx,
columns: [:project_id_convert_to_bigint, :status],
options: { where: "type::text = 'Ci::Build'::text AND (status::text = ANY (ARRAY['running'::character varying::text, 'pending'::character varying::text, 'created'::character varying::text]))" } # rubocop:disable Layout/LineLength -- it's just too long
options: { where: "type::text = 'Ci::Build'::text AND (status::text = ANY (ARRAY['running'::character varying::text, 'pending'::character varying::text, 'created'::character varying::text]))" }
},
{
name: :p_ci_builds_status_created_at_project_id_bigint_idx,
......
......@@ -46,7 +46,7 @@ class SyncIndexForPipelinesIdBigintRelated < Gitlab::Database::Migration[2.2]
{
name: :idx_ci_pipelines_on_user_id_and_id_and_cancelable_status_bigint,
columns: [:user_id, :id_convert_to_bigint],
options: { where: "((status)::text = ANY (ARRAY[('running'::character varying)::text, ('waiting_for_resource'::character varying)::text, ('preparing'::character varying)::text, ('pending'::character varying)::text, ('created'::character varying)::text, ('scheduled'::character varying)::text]))" } # rubocop:disable Layout/LineLength -- Just too long
options: { where: "((status)::text = ANY (ARRAY[('running'::character varying)::text, ('waiting_for_resource'::character varying)::text, ('preparing'::character varying)::text, ('pending'::character varying)::text, ('created'::character varying)::text, ('scheduled'::character varying)::text]))" }
},
{
name: :idx_ci_pipelines_on_user_id_and_user_not_verified_bigint,
......
......@@ -70,7 +70,7 @@ class SwapCiPipelinesPkWithBigintPCiBuildsPCiStages < Gitlab::Database::Migratio
name: :idx_ci_pipelines_on_user_id_and_id_and_cancelable_status_bigint,
old_name: :index_ci_pipelines_on_user_id_and_id_and_cancelable_status,
columns: [:user_id, :id_convert_to_bigint],
options: { where: "((status)::text = ANY (ARRAY[('running'::character varying)::text, ('waiting_for_resource'::character varying)::text, ('preparing'::character varying)::text, ('pending'::character varying)::text, ('created'::character varying)::text, ('scheduled'::character varying)::text]))" } # rubocop:disable Layout/LineLength -- Just too long
options: { where: "((status)::text = ANY (ARRAY[('running'::character varying)::text, ('waiting_for_resource'::character varying)::text, ('preparing'::character varying)::text, ('pending'::character varying)::text, ('created'::character varying)::text, ('scheduled'::character varying)::text]))" }
},
{
name: :idx_ci_pipelines_on_user_id_and_user_not_verified_bigint,
......@@ -235,7 +235,7 @@ def remove_integer_foreign_keys_and_rename_bigint
)
if fk_metadata[:partitioned]
rename_partitioned_foreign_key(fk_metadata[:source_table], tmp_name(fk_metadata), fk_metadata[:name]) # rubocop:disable Migration/WithLockRetriesDisallowedMethod -- needed here
rename_partitioned_foreign_key(fk_metadata[:source_table], tmp_name(fk_metadata), fk_metadata[:name])
else
rename_constraint(fk_metadata[:source_table], tmp_name(fk_metadata), fk_metadata[:name])
end
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment