Skip to content
Snippets Groups Projects
Commit 46bae27b authored by Suzanne Selhorn's avatar Suzanne Selhorn
Browse files

Merge branch 'code_review_test_locally_please' into 'master'

While reviewing, should test the merge request locally

See merge request !95420
parents 1cc86111 f7c6bed2
No related branches found
No related tags found
2 merge requests!96059Draft: Add GraphQL query for deployment details,!95420While reviewing, should test the merge request locally
Pipeline #615228586 passed
......@@ -468,6 +468,8 @@ experience, refactors the existing code). Then:
- Offer alternative implementations, but assume the author already considered
them. ("What do you think about using a custom validator here?")
- Seek to understand the author's perspective.
- Check out the branch, and test the changes locally. You can decide how much manual testing you want to perform.
Your testing might result in opportunities to add automated tests.
- If you don't understand a piece of code, _say so_. There's a good chance
someone else would be confused by it as well.
- Ensure the author is clear on what is required from them to address/resolve the suggestion.
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment