Skip to content
Snippets Groups Projects
Commit 3ff05756 authored by Z.J. van de Weg's avatar Z.J. van de Weg
Browse files

Issue creation now accepts trailing whitespace

parent 60c2d590
No related branches found
No related tags found
1 merge request!912CE upstream
......@@ -2,7 +2,9 @@ module Gitlab
module ChatCommands
class IssueCreate < IssueCommand
def self.match(text)
/\Aissue\s+create\s+(?<title>[^\n]*)\n*(?<description>.*)\z/.match(text)
# we can not match \n with the dot by passing the m modifier as than
# the title and description are not seperated
/\Aissue\s+create\s+(?<title>[^\n]*)\n*(?<description>(.|\n)*)/.match(text)
end
def self.help_message
......@@ -15,7 +17,7 @@ def self.allowed?(project, user)
def execute(match)
title = match[:title]
description = match[:description]
description = match[:description].to_s.rstrip
Issues::CreateService.new(project, current_user, title: title, description: description).execute
end
......
......@@ -32,6 +32,15 @@
expect(Issue.last.description).to eq(description)
end
end
context "with more newlines between the title and the description" do
let(:description) { "Surfin bird" }
let(:regex_match) { described_class.match("issue create bird is the word\n\n#{description}\n") }
it 'creates the issue' do
expect { subject }.to change { project.issues.count }.by(1)
end
end
end
describe '.match' do
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment