Merge branch 'mk/fix-flaky-test-ntp-server-dependency' into 'master'

Geo: Fix flaky test depending on NTP servers

Closes gitlab-org/quality/engineering-productivity/master-broken-incidents#5117

See merge request !143293



Merged-by: Igor Drozdov <idrozdov@gitlab.com>
Approved-by: Prabakaran Murugesan <pmurugesan@gitlab.com>
Approved-by: Igor Drozdov <idrozdov@gitlab.com>
Co-authored-by: Mike Kozono <mkozono@gitlab.com>

ee/spec/lib/system_check/geo/clocks_synchronization_check_spec.rb

@@ -62,6 +62,9 @@
       end
 
       it 'passes with a success message' do
+        ntp_response = instance_double(Net::NTP::Response, offset: 0.1234)
+        expect(Net::NTP).to receive(:get).with(ntp_host_env, ntp_port_env, ntp_timeout_env.to_i)
+          .and_return(ntp_response)
         expect_pass
 
         expect(subject.multi_check).to be_truthy
@@ -70,6 +73,9 @@
 
     context 'with default NTP connection params' do
       it 'passes with a success message' do
+        ntp_response = instance_double(Net::NTP::Response, offset: 0.1234)
+        expect(Net::NTP).to receive(:get).with('pool.ntp.org', 'ntp', Net::NTP::TIMEOUT.to_i)
+          .and_return(ntp_response)
         expect_pass
 
         expect(subject.multi_check).to be_truthy