Skip to content
Snippets Groups Projects
Commit 39219aed authored by Gerardo Navarro's avatar Gerardo Navarro :speech_balloon:
Browse files

Adjust naming in admin network settings

- Lowercase the "rate limits" part of the section titles in the admin
  network settings page to be consistent with the rest of the
  application settings page.
  e.g. `Files API rate limits` instead of `Files API Rate Limits`
- Pluralize the "rate limits" part of the section titles in the admin
  network settings page,
  e.g. `Users API rate limits` instead of `Users API rate limit`

Changelog: other
parent ac3de7a0
1 merge request!147536Adjust naming in admin network settings
%section.settings.no-animate#js-gitlab-shell-operation-limits-settings{ class: ('expanded' if expanded_by_default?), 'data-testid': 'gitlab-shell-operation-limits' }
.settings-header
%h4.settings-title.js-settings-toggle.js-settings-toggle-trigger-only
= s_('ShellOperations|Git SSH operations rate limit')
= s_('ShellOperations|Git SSH operations rate limits')
= render Pajamas::ButtonComponent.new(button_options: { class: 'js-settings-toggle' }) do
= expanded_by_default? ? _('Collapse') : _('Expand')
%p.gl-text-secondary
......
%section.settings.as-members-api-limits.no-animate#js-members-api-limits-settings{ class: ('expanded' if expanded_by_default?) }
.settings-header
%h4.settings-title.js-settings-toggle.js-settings-toggle-trigger-only
= _('Members API rate limit')
= _('Members API rate limits')
= render Pajamas::ButtonComponent.new(button_options: { class: 'js-settings-toggle' }) do
= expanded_by_default? ? _('Collapse') : _('Expand')
%p.gl-text-secondary
......
%section.settings.as-projects-api-limits.no-animate#js-projects-api-limits-settings{ class: ('expanded' if expanded_by_default?) }
.settings-header
%h4.settings-title.js-settings-toggle.js-settings-toggle-trigger-only
= _('Projects API rate limit')
= _('Projects API rate limits')
= render Pajamas::ButtonComponent.new(button_options: { class: 'js-settings-toggle' }) do
= expanded_by_default? ? _('Collapse') : _('Expand')
%p.gl-text-secondary
......
......@@ -41,7 +41,7 @@
%section.settings.as-files-limits.no-animate#js-files-limits-settings{ class: ('expanded' if expanded_by_default?) }
.settings-header
%h4.settings-title.js-settings-toggle.js-settings-toggle-trigger-only
= _('Files API Rate Limits')
= _('Files API rate limits')
= render Pajamas::ButtonComponent.new(button_options: { class: 'js-settings-toggle' }) do
= expanded_by_default? ? _('Collapse') : _('Expand')
%p.gl-text-secondary
......@@ -75,7 +75,7 @@
%section.settings.as-git-lfs-limits.no-animate#js-git-lfs-limits-settings{ class: ('expanded' if expanded_by_default?) }
.settings-header
%h4.settings-title.js-settings-toggle.js-settings-toggle-trigger-only
= _('Git LFS Rate Limits')
= _('Git LFS rate limits')
= render Pajamas::ButtonComponent.new(button_options: { class: 'js-settings-toggle' }) do
= expanded_by_default? ? _('Collapse') : _('Expand')
%p.gl-text-secondary
......@@ -116,7 +116,7 @@
%section.settings.as-issue-limits.no-animate#js-issue-limits-settings{ class: ('expanded' if expanded_by_default?) }
.settings-header
%h4.settings-title.js-settings-toggle.js-settings-toggle-trigger-only
= _('Issues Rate Limits')
= _('Issues rate limits')
= render Pajamas::ButtonComponent.new(button_options: { class: 'js-settings-toggle' }) do
= expanded_by_default? ? _('Collapse') : _('Expand')
%p.gl-text-secondary
......@@ -128,7 +128,7 @@
%section.settings.as-note-limits.no-animate#js-note-limits-settings{ class: ('expanded' if expanded_by_default?) }
.settings-header
%h4.settings-title.js-settings-toggle.js-settings-toggle-trigger-only
= _('Notes rate limit')
= _('Notes rate limits')
= render Pajamas::ButtonComponent.new(button_options: { class: 'js-settings-toggle' }) do
= expanded_by_default? ? _('Collapse') : _('Expand')
%p.gl-text-secondary
......@@ -140,7 +140,7 @@
%section.settings.as-users-api-limits.no-animate#js-users-api-limits-settings{ class: ('expanded' if expanded_by_default?) }
.settings-header
%h4.settings-title.js-settings-toggle.js-settings-toggle-trigger-only
= _('Users API rate limit')
= _('Users API rate limits')
= render Pajamas::ButtonComponent.new(button_options: { class: 'js-settings-toggle' }) do
= expanded_by_default? ? _('Collapse') : _('Expand')
%p.gl-text-secondary
......
......@@ -21512,7 +21512,7 @@ msgstr ""
msgid "Files"
msgstr ""
 
msgid "Files API Rate Limits"
msgid "Files API rate limits"
msgstr ""
 
msgid "Files breadcrumb"
......@@ -22634,15 +22634,15 @@ msgstr ""
msgid "Git"
msgstr ""
 
msgid "Git LFS Rate Limits"
msgstr ""
msgid "Git LFS is not enabled on this GitLab server, contact your admin."
msgstr ""
 
msgid "Git LFS objects will be synced if LFS is %{docs_link_start}enabled for the project%{docs_link_end}. Push mirrors will %{strong_open}not%{strong_close} sync LFS objects over SSH."
msgstr ""
 
msgid "Git LFS rate limits"
msgstr ""
msgid "Git LFS status:"
msgstr ""
 
......@@ -27774,9 +27774,6 @@ msgstr ""
msgid "Issues Completed"
msgstr ""
 
msgid "Issues Rate Limits"
msgstr ""
msgid "Issues and merge requests"
msgstr ""
 
......@@ -27795,6 +27792,9 @@ msgstr ""
msgid "Issues must match this scope to appear in this list."
msgstr ""
 
msgid "Issues rate limits"
msgstr ""
msgid "Issues with comments, merge requests with diffs and comments, labels, milestones, snippets, and other project entities"
msgstr ""
 
......@@ -30979,7 +30979,7 @@ msgstr ""
msgid "Members"
msgstr ""
 
msgid "Members API rate limit"
msgid "Members API rate limits"
msgstr ""
 
msgid "Members can be added by project %{i_open}Maintainers%{i_close} or %{i_open}Owners%{i_close}"
......@@ -33675,7 +33675,7 @@ msgstr ""
msgid "Notes"
msgstr ""
 
msgid "Notes rate limit"
msgid "Notes rate limits"
msgstr ""
 
msgid "Notes|Are you sure you want to cancel creating this %{commentType}?"
......@@ -40127,7 +40127,7 @@ msgstr ""
msgid "Projects API"
msgstr ""
 
msgid "Projects API rate limit"
msgid "Projects API rate limits"
msgstr ""
 
msgid "Projects Successfully Retrieved"
......@@ -47419,7 +47419,7 @@ msgstr ""
msgid "SharedRunnersMinutesSettings|When you reset the compute usage for this namespace, the compute usage changes to zero."
msgstr ""
 
msgid "ShellOperations|Git SSH operations rate limit"
msgid "ShellOperations|Git SSH operations rate limits"
msgstr ""
 
msgid "ShellOperations|Limit the number of Git operations a user can perform per minute, per repository."
......@@ -55256,7 +55256,7 @@ msgstr ""
msgid "Users"
msgstr ""
 
msgid "Users API rate limit"
msgid "Users API rate limits"
msgstr ""
 
msgid "Users can launch a development environment from a GitLab browser tab when the %{linkStart}Gitpod%{linkEnd} integration is enabled."
......@@ -735,7 +735,7 @@
expect(current_settings.dns_rebinding_protection_enabled).to be false
end
it 'changes User and IP Rate Limits settings' do
it 'changes User and IP rate limits settings' do
visit network_admin_application_settings_path
page.within('.as-ip-limits') do
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment