Update PreventAddingColumns cop

3335006c · Max Orefice · GitLab · 8a9030bc · 3335006c · 3335006c
Verified Commit 3335006c authored 3 months ago by Max Orefice Committed by GitLab 3 months ago
--- a/db/migrate/20231031114050_add_highest_severity_and_vulnerability_count_into_sbom_occurrences.rb
+++ b/db/migrate/20231031114050_add_highest_severity_and_vulnerability_count_into_sbom_occurrences.rb
@@ -4,9 +4,7 @@ class AddHighestSeverityAndVulnerabilityCountIntoSbomOccurrences < Gitlab::Datab
  milestone '16.7'

  def change
-    add_column :sbom_occurrences, :highest_severity, :smallint, null: true # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
-    # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
+    add_column :sbom_occurrences, :highest_severity, :smallint, null: true
    add_column :sbom_occurrences, :vulnerability_count, :integer, null: false, default: 0
-    # rubocop:enable Migration/PreventAddingColumns
  end
 end
--- a/db/migrate/20231221033539_create_sbom_source_packages_table.rb
+++ b/db/migrate/20231221033539_create_sbom_source_packages_table.rb
@@ -13,9 +13,7 @@ class CreateSbomSourcePackagesTable < Gitlab::Database::Migration[2.2]
  # rubocop:disable Migration/PreventIndexCreation -- Legacy migration
  def up
    with_lock_retries do
-      # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
      add_column :sbom_occurrences, :source_package_id, :bigint, if_not_exists: true
-      # rubocop:enable Migration/PreventAddingColumns
    end

    create_table :sbom_source_packages, if_not_exists: true do |t|

--- a/db/migrate/20240104142200_add_index_sent_notifications_on_issue_email_participant_id.rb
+++ b/db/migrate/20240104142200_add_index_sent_notifications_on_issue_email_participant_id.rb
@@ -7,11 +7,9 @@ class AddIndexSentNotificationsOnIssueEmailParticipantId < Gitlab::Database::Mig

  INDEX_NAME = 'index_sent_notifications_on_issue_email_participant_id'

-  # rubocop:disable Migration/PreventIndexCreation -- Legacy migration
  def up
    add_concurrent_index :sent_notifications, :issue_email_participant_id, name: INDEX_NAME
  end
-  # rubocop:enable Migration/PreventIndexCreation

  def down
    remove_concurrent_index_by_name :sent_notifications, INDEX_NAME

--- a/db/migrate/20240109145839_add_partition_id_to_pipeline_config.rb
+++ b/db/migrate/20240109145839_add_partition_id_to_pipeline_config.rb
@@ -5,8 +5,6 @@ class AddPartitionIdToPipelineConfig < Gitlab::Database::Migration[2.2]
  enable_lock_retries!

  def change
-    # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
    add_column(:ci_pipelines_config, :partition_id, :bigint, default: 100, null: false)
-    # rubocop:enable Migration/PreventAddingColumns
  end
 end
--- a/db/migrate/20240129175101_add_archived_and_traversal_ids_columns_to_sbom_occurrences.rb
+++ b/db/migrate/20240129175101_add_archived_and_traversal_ids_columns_to_sbom_occurrences.rb
@@ -4,11 +4,7 @@ class AddArchivedAndTraversalIdsColumnsToSbomOccurrences < Gitlab::Database::Mig
  milestone '16.9'

  def change
-    # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
    add_column :sbom_occurrences, :archived, :boolean, default: false, null: false
-    # rubocop:enable Migration/PreventAddingColumns
-    # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
    add_column :sbom_occurrences, :traversal_ids, 'bigint[]', default: [], null: false
-    # rubocop:enable Migration/PreventAddingColumns
  end
 end
--- a/db/migrate/20240212170304_add_ancestors_column_to_sbom_occurrences.rb
+++ b/db/migrate/20240212170304_add_ancestors_column_to_sbom_occurrences.rb
@@ -6,9 +6,7 @@ class AddAncestorsColumnToSbomOccurrences < Gitlab::Database::Migration[2.2]
  enable_lock_retries!

  def up
-    # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
    add_column :sbom_occurrences, :ancestors, :jsonb, default: [], null: false
-    # rubocop:enable Migration/PreventAddingColumns
  end

  def down

--- a/db/migrate/20240320110318_add_file_final_path_to_packages_package_files.rb
+++ b/db/migrate/20240320110318_add_file_final_path_to_packages_package_files.rb
@@ -6,9 +6,7 @@ class AddFileFinalPathToPackagesPackageFiles < Gitlab::Database::Migration[2.2]

  def up
    with_lock_retries do
-      # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
      add_column :packages_package_files, :file_final_path, :text, if_not_exists: true
-      # rubocop:enable Migration/PreventAddingColumns
    end

    add_text_limit :packages_package_files, :file_final_path, 1024

--- a/db/migrate/20240516133122_add_partition_id_to_ci_pipeline_message.rb
+++ b/db/migrate/20240516133122_add_partition_id_to_ci_pipeline_message.rb
@@ -4,8 +4,6 @@ class AddPartitionIdToCiPipelineMessage < Gitlab::Database::Migration[2.2]
  milestone '17.1'

  def change
-    # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
    add_column(:ci_pipeline_messages, :partition_id, :bigint, default: 100, null: false)
-    # rubocop:enable Migration/PreventAddingColumns
  end
 end
--- a/db/migrate/20240517192053_add_advanced_token_scope.rb
+++ b/db/migrate/20240517192053_add_advanced_token_scope.rb
@@ -7,9 +7,7 @@ class AddAdvancedTokenScope < Gitlab::Database::Migration[2.2]

  def up
    with_lock_retries do
-      # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
      add_column :personal_access_tokens, :advanced_scopes, :text, if_not_exists: true
-      # rubocop:enable Migration/PreventAddingColumns
    end

    add_text_limit :personal_access_tokens, :advanced_scopes, 4096

--- a/db/migrate/20240627121919_add_auto_canceled_by_partition_id_to_ci_pipelines.rb
+++ b/db/migrate/20240627121919_add_auto_canceled_by_partition_id_to_ci_pipelines.rb
@@ -4,6 +4,8 @@ class AddAutoCanceledByPartitionIdToCiPipelines < Gitlab::Database::Migration[2.
  milestone '17.2'

  def change
-    add_column :ci_pipelines, :auto_canceled_by_partition_id, :bigint # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
+    # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
+    add_column :ci_pipelines, :auto_canceled_by_partition_id, :bigint
+    # rubocop:enable Migration/PreventAddingColumns
  end
 end
--- a/db/migrate/20240729130349_add_project_id_to_packages_package_files.rb
+++ b/db/migrate/20240729130349_add_project_id_to_packages_package_files.rb
@@ -4,6 +4,6 @@ class AddProjectIdToPackagesPackageFiles < Gitlab::Database::Migration[2.2]
  milestone '17.3'

  def change
-    add_column :packages_package_files, :project_id, :bigint # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
+    add_column :packages_package_files, :project_id, :bigint
  end
 end
--- a/db/migrate/20240730172815_add_project_id_to_vulnerability_occurrence_pipelines.rb
+++ b/db/migrate/20240730172815_add_project_id_to_vulnerability_occurrence_pipelines.rb
@@ -4,6 +4,6 @@ class AddProjectIdToVulnerabilityOccurrencePipelines < Gitlab::Database::Migrati
  milestone '17.3'

  def change
-    add_column :vulnerability_occurrence_pipelines, :project_id, :bigint # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
+    add_column :vulnerability_occurrence_pipelines, :project_id, :bigint
  end
 end
--- a/db/migrate/20240802194745_add_project_id_to_merge_request_diff_commits_b5377a7a34.rb
+++ b/db/migrate/20240802194745_add_project_id_to_merge_request_diff_commits_b5377a7a34.rb
@@ -4,9 +4,7 @@ class AddProjectIdToMergeRequestDiffCommitsB5377a7a34 < Gitlab::Database::Migrat
  milestone '17.3'

  def up
-    # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
    add_column :merge_request_diff_commits_b5377a7a34, :project_id, :bigint
-    # rubocop:enable Migration/PreventAddingColumns
  end

  def down

--- a/db/migrate/20240802203135_add_project_id_to_merge_request_diff_files99208b8fac.rb
+++ b/db/migrate/20240802203135_add_project_id_to_merge_request_diff_files99208b8fac.rb
@@ -4,7 +4,7 @@ class AddProjectIdToMergeRequestDiffFiles99208b8fac < Gitlab::Database::Migratio
  milestone '17.3'

  def up
-    add_column :merge_request_diff_files_99208b8fac, :project_id, :bigint # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
+    add_column :merge_request_diff_files_99208b8fac, :project_id, :bigint
  end

  def down

--- a/db/migrate/20240805080941_add_organization_id_to_personal_access_tokens.rb
+++ b/db/migrate/20240805080941_add_organization_id_to_personal_access_tokens.rb
@@ -9,9 +9,7 @@ class AddOrganizationIdToPersonalAccessTokens < Gitlab::Database::Migration[2.2]

  def up
    with_lock_retries do
-      # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
      add_column :personal_access_tokens, :organization_id, :bigint, default: DEFAULT_ORGANIZATION_ID, null: false,
-        # rubocop:enable Migration/PreventAddingColumns
        if_not_exists: true
    end
    # rubocop:disable Migration/PreventIndexCreation -- Legacy migration

--- a/db/migrate/20240805081832_add_reachability_column_to_sbom_occurances_table.rb
+++ b/db/migrate/20240805081832_add_reachability_column_to_sbom_occurances_table.rb
@@ -4,7 +4,7 @@ class AddReachabilityColumnToSbomOccurancesTable < Gitlab::Database::Migration[2
  milestone '17.4'
  def up
    with_lock_retries do
-      add_column :sbom_occurrences, :reachability, :smallint, default: 0 # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
+      add_column :sbom_occurrences, :reachability, :smallint, default: 0 # -- Legacy migration
    end
  end


--- a/db/migrate/20240822195511_add_notification_cols_to_personal_access_tokens.rb
+++ b/db/migrate/20240822195511_add_notification_cols_to_personal_access_tokens.rb
@@ -4,15 +4,9 @@ class AddNotificationColsToPersonalAccessTokens < Gitlab::Database::Migration[2.
  milestone '17.4'

  def up
-    # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
    add_column :personal_access_tokens, :seven_days_notification_sent_at, :datetime_with_timezone
-    # rubocop:enable Migration/PreventAddingColumns
-    # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
    add_column :personal_access_tokens, :thirty_days_notification_sent_at, :datetime_with_timezone
-    # rubocop:enable Migration/PreventAddingColumns
-    # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
    add_column :personal_access_tokens, :sixty_days_notification_sent_at, :datetime_with_timezone
-    # rubocop:enable Migration/PreventAddingColumns
  end

  def down

--- a/db/migrate/20241014081022_add_project_id_to_ci_pipeline_messages.rb
+++ b/db/migrate/20241014081022_add_project_id_to_ci_pipeline_messages.rb
@@ -4,6 +4,6 @@ class AddProjectIdToCiPipelineMessages < Gitlab::Database::Migration[2.2]
  milestone '17.6'

  def change
-    add_column(:ci_pipeline_messages, :project_id, :bigint) # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
+    add_column(:ci_pipeline_messages, :project_id, :bigint)
  end
 end
--- a/db/migrate/20241021141853_add_auto_resolved_to_vulnerabilities.rb
+++ b/db/migrate/20241021141853_add_auto_resolved_to_vulnerabilities.rb
@@ -4,8 +4,6 @@ class AddAutoResolvedToVulnerabilities < Gitlab::Database::Migration[2.2]
  milestone '17.6'

  def change
-    # rubocop:disable Migration/PreventAddingColumns -- Legacy migration
    add_column :vulnerabilities, :auto_resolved, :boolean, null: false, default: false, if_not_exists: true
-    # rubocop:enable Migration/PreventAddingColumns
  end
 end
--- a/db/post_migrate/20231114034507_add_merge_request_diffs_project_id_index_async.rb
+++ b/db/post_migrate/20231114034507_add_merge_request_diffs_project_id_index_async.rb
@@ -6,11 +6,9 @@ class AddMergeRequestDiffsProjectIdIndexAsync < Gitlab::Database::Migration[2.2]

  INDEX_NAME = 'index_merge_request_diffs_on_project_id'

-  # rubocop:disable Migration/PreventIndexCreation -- Legacy migration
  def up
    prepare_async_index :merge_request_diffs, :project_id, name: INDEX_NAME
  end
-  # rubocop:enable Migration/PreventIndexCreation

  def down
    unprepare_async_index :merge_request_diffs, :project_id, name: INDEX_NAME