Skip to content
Snippets Groups Projects
Verified Commit 2a66e54d authored by Subashis  Chakraborty's avatar Subashis Chakraborty :one: Committed by GitLab
Browse files

Dry up specs for resolve vulnerability

parent 631672ab
No related branches found
No related tags found
2 merge requests!181325Fix ambiguous `created_at` in project.rb,!176036Dry up specs for resolve vulnerability
......@@ -45,6 +45,23 @@ def expect_tracked_error(error)
expect(Gitlab::ErrorTracking).to have_received(:track_exception).with(error)
end
def expect_tracked_internal_event(event_name, status)
internal_merge_request_id = status == "error" ? nil : merge_request.id
expect(Gitlab::InternalEvents).to receive(:track_event).with(event_name,
project: project,
user: user,
namespace: project.namespace,
category: described_class.to_s,
additional_properties: {
property: status,
label: "resolve_vulnerability",
vulnerability_id: vulnerability.id,
internal_merge_request_id: internal_merge_request_id,
language: "C"
}
)
end
RSpec.shared_examples "a resolve vulnerability completion" do
before do
stub_licensed_features(security_dashboard: true)
......@@ -242,19 +259,7 @@ def expect_tracked_error(error)
end
it 'tracks internal event with success' do
expect(Gitlab::InternalEvents).to receive(:track_event).with('track_mr_creation_from_vr',
project: project,
user: user,
namespace: project.namespace,
category: described_class.to_s,
additional_properties: {
property: "success",
label: "resolve_vulnerability",
vulnerability_id: vulnerability.id,
internal_merge_request_id: merge_request.id,
language: "C"
}
)
expect_tracked_internal_event("track_mr_creation_from_vr", "success")
resolve.execute
end
......@@ -289,19 +294,7 @@ def expect_tracked_error(error)
end
it 'tracks internal event with success' do
expect(Gitlab::InternalEvents).to receive(:track_event).with('track_mr_creation_from_vr_in_mr_request',
project: project,
user: user,
namespace: project.namespace,
category: described_class.to_s,
additional_properties: {
property: "success",
label: "resolve_vulnerability",
vulnerability_id: vulnerability.id,
internal_merge_request_id: merge_request.id,
language: "C"
}
)
expect_tracked_internal_event("track_mr_creation_from_vr_in_mr_request", "success")
resolve.execute
end
......@@ -352,19 +345,7 @@ def expect_tracked_error(error)
end
it 'tracks internal event with error' do
expect(Gitlab::InternalEvents).to receive(:track_event).with('track_mr_creation_from_vr',
project: project,
user: user,
namespace: project.namespace,
category: described_class.to_s,
additional_properties: {
property: "error",
label: "resolve_vulnerability",
vulnerability_id: vulnerability.id,
internal_merge_request_id: nil,
language: "C"
}
)
expect_tracked_internal_event("track_mr_creation_from_vr", "error")
resolve.execute
end
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment