Skip to content
Snippets Groups Projects
Commit 28f635ff authored by Frédéric Caplette's avatar Frédéric Caplette
Browse files

Remove feature flag for pipeline editor drawer

The pipeline editor drawer is a section that
helps new user get started. It has been multiple
months since this feature has been enabled by default
for .com and self hosted without any incident.
This commit removes that flag pipeline_editor_drawer.

Changelog: other
parent b7e11a3c
No related branches found
No related tags found
1 merge request!72237Remove feature flag for pipeline editor drawer
<script>
import glFeatureFlagMixin from '~/vue_shared/mixins/gl_feature_flags_mixin';
import CommitSection from './components/commit/commit_section.vue';
import PipelineEditorDrawer from './components/drawer/pipeline_editor_drawer.vue';
import PipelineEditorFileNav from './components/file_nav/pipeline_editor_file_nav.vue';
......@@ -15,7 +14,6 @@ export default {
PipelineEditorHeader,
PipelineEditorTabs,
},
mixins: [glFeatureFlagMixin()],
props: {
ciConfigData: {
type: Object,
......@@ -44,9 +42,6 @@ export default {
showCommitForm() {
return TABS_WITH_COMMIT_FORM.includes(this.currentTab);
},
showPipelineDrawer() {
return this.glFeatures.pipelineEditorDrawer;
},
},
methods: {
setCurrentTab(tabName) {
......@@ -77,6 +72,6 @@ export default {
:commit-sha="commitSha"
v-on="$listeners"
/>
<pipeline-editor-drawer v-if="showPipelineDrawer" />
<pipeline-editor-drawer />
</div>
</template>
......@@ -3,7 +3,6 @@
class Projects::Ci::PipelineEditorController < Projects::ApplicationController
before_action :check_can_collaborate!
before_action do
push_frontend_feature_flag(:pipeline_editor_drawer, @project, default_enabled: :yaml)
push_frontend_feature_flag(:pipeline_editor_mini_graph, @project, default_enabled: :yaml)
push_frontend_feature_flag(:schema_linting, @project, default_enabled: :yaml)
end
......
---
name: pipeline_editor_drawer
introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/60856
rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/329806
milestone: '13.12'
type: development
group: group::pipeline authoring
default_enabled: true
......@@ -25,7 +25,6 @@ describe('Pipeline editor home wrapper', () => {
},
provide: {
glFeatures: {
pipelineEditorDrawer: true,
...glFeatures,
},
},
......@@ -94,12 +93,4 @@ describe('Pipeline editor home wrapper', () => {
expect(findCommitSection().exists()).toBe(true);
});
});
describe('Pipeline drawer', () => {
it('hides the drawer when the feature flag is off', () => {
createComponent({ glFeatures: { pipelineEditorDrawer: false } });
expect(findPipelineEditorDrawer().exists()).toBe(false);
});
});
});
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment