Merge branch 'morefice/p-ci-stages-fks' into 'master'

Replace FKs for p_ci_stages

See merge request !145899



Merged-by: Marius Bobin <mbobin@gitlab.com>
Approved-by: Panos Kanellidis <pkanellidis@gitlab.com>
Approved-by: Marius Bobin <mbobin@gitlab.com>
Co-authored-by: Maxime Orefice <morefice@gitlab.com>

db/post_migrate/20240226141402_replace_ci_builds_ci_stages_foreign_key.rb

+# frozen_string_literal: true
+
+class ReplaceCiBuildsCiStagesForeignKey < Gitlab::Database::Migration[2.2]
+  include Gitlab::Database::PartitioningMigrationHelpers::ForeignKeyHelpers
+
+  milestone '16.10'
+  disable_ddl_transaction!
+
+  TABLE_NAME = :p_ci_builds
+  FK_NAME = :tmp_fk_3a9eaa254d_p
+
+  def up
+    add_concurrent_partitioned_foreign_key(
+      TABLE_NAME,
+      :p_ci_stages,
+      name: FK_NAME,
+      column: [:partition_id, :stage_id],
+      target_column: [:partition_id, :id],
+      on_delete: :cascade,
+      on_update: :cascade,
+      validate: false,
+      reverse_lock_order: true
+    )
+
+    prepare_partitioned_async_foreign_key_validation(TABLE_NAME, name: FK_NAME)
+  end
+
+  def down
+    unprepare_partitioned_async_foreign_key_validation(TABLE_NAME, name: FK_NAME)
+
+    Gitlab::Database::PostgresPartitionedTable.each_partition(TABLE_NAME) do |partition|
+      remove_foreign_key_if_exists(partition.identifier, name: FK_NAME)
+    end
+  end
+end

db/schema_migrations/20240226141402

+dd471c5a2b970eaee32c4b713656df90d36f11b6edb26f84364fa5bf26715fcf
\ No newline at end of file

db/structure.sql

@@ -32324,6 +32324,9 @@ ALTER TABLE issue_search_data
 ALTER TABLE issue_search_data
     ADD CONSTRAINT issue_search_data_project_id_fkey FOREIGN KEY (project_id) REFERENCES projects(id) ON DELETE CASCADE;
+ALTER TABLE ONLY ci_builds
+    ADD CONSTRAINT tmp_fk_3a9eaa254d_p FOREIGN KEY (partition_id, stage_id) REFERENCES p_ci_stages(partition_id, id) ON UPDATE CASCADE ON DELETE CASCADE NOT VALID;
+
 ALTER TABLE ONLY user_follow_users
     ADD CONSTRAINT user_follow_users_followee_id_fkey FOREIGN KEY (followee_id) REFERENCES users(id) ON DELETE CASCADE;