Fix Layout/ArgumentAlignment offenses 32

Changelog: other

EE: true

.rubocop_todo/layout/argument_alignment.yml

@@ -18,23 +18,6 @@ Layout/ArgumentAlignment:
     - 'app/graphql/mutations/work_items/delete.rb'
     - 'app/graphql/mutations/work_items/update.rb'
     - 'app/graphql/resolvers/admin/analytics/usage_trends/measurements_resolver.rb'
-    - 'ee/app/graphql/ee/mutations/issues/create.rb'
-    - 'ee/app/graphql/ee/mutations/issues/update.rb'
-    - 'ee/app/graphql/ee/mutations/work_items/create.rb'
-    - 'ee/app/graphql/ee/mutations/work_items/update.rb'
-    - 'ee/app/graphql/ee/resolvers/issues/base_parent_resolver.rb'
-    - 'ee/app/graphql/ee/resolvers/issues/base_resolver.rb'
-    - 'ee/app/graphql/ee/resolvers/namespace_projects_resolver.rb'
-    - 'ee/app/graphql/ee/resolvers/work_items_resolver.rb'
-    - 'ee/app/graphql/ee/types/alert_management/http_integration_type.rb'
-    - 'ee/app/graphql/ee/types/boards/board_issue_input_base_type.rb'
-    - 'ee/app/graphql/ee/types/boards/board_issue_input_type.rb'
-    - 'ee/app/graphql/ee/types/boards/negated_board_issue_input_type.rb'
-    - 'ee/app/graphql/ee/types/branch_protections/base_access_level_type.rb'
-    - 'ee/app/graphql/ee/types/branch_rules/branch_protection_type.rb'
-    - 'ee/app/graphql/ee/types/ci/runner_countable_connection_type.rb'
-    - 'ee/app/graphql/ee/types/deployment_type.rb'
-    - 'ee/app/graphql/ee/types/environment_type.rb'
     - 'ee/app/graphql/mutations/iterations/cadences/destroy.rb'
     - 'ee/app/graphql/mutations/iterations/create.rb'
     - 'ee/app/graphql/mutations/iterations/update.rb'

ee/app/graphql/ee/mutations/issues/create.rb

@@ -11,19 +11,19 @@ module Create
           include ::Mutations::Issues::CommonEEMutationArguments
 
           argument :epic_id, ::Types::GlobalIDType[::Epic],
-                   required: false,
-                   description: 'ID of an epic to associate the issue with.'
+            required: false,
+            description: 'ID of an epic to associate the issue with.'
           argument :iteration_id, ::Types::GlobalIDType[::Iteration],
-                   required: false,
-                   description: 'Global iteration ID. Mutually exlusive argument with `iterationWildcardId`.'
+            required: false,
+            description: 'Global iteration ID. Mutually exlusive argument with `iterationWildcardId`.'
           argument :iteration_wildcard_id, ::Types::IssueCreationIterationWildcardIdEnum,
-                   required: false,
-                   description: 'Iteration wildcard ID. Supported values are: `CURRENT`. ' \
-                                'Mutually exclusive argument with `iterationId`. ' \
-                                'iterationCadenceId also required when this argument is provided.'
+            required: false,
+            description: 'Iteration wildcard ID. Supported values are: `CURRENT`. ' \
+                         'Mutually exclusive argument with `iterationId`. ' \
+                         'iterationCadenceId also required when this argument is provided.'
           argument :iteration_cadence_id, ::Types::GlobalIDType[::Iterations::Cadence],
-                   required: false,
-                   description: 'Global iteration cadence ID. Required when `iterationWildcardId` is provided.'
+            required: false,
+            description: 'Global iteration cadence ID. Required when `iterationWildcardId` is provided.'
         end
 
         override :resolve

ee/app/graphql/ee/mutations/issues/update.rb

@@ -10,9 +10,9 @@ module Update
           include ::Mutations::Issues::CommonEEMutationArguments
 
           argument :epic_id, ::Types::GlobalIDType[::Epic],
-                   required: false,
-                   loads: ::Types::EpicType,
-                   description: 'ID of the parent epic. NULL when removing the association.'
+            required: false,
+            loads: ::Types::EpicType,
+            description: 'ID of the parent epic. NULL when removing the association.'
         end
 
         def resolve(**args)

ee/app/graphql/ee/mutations/work_items/update.rb

@@ -8,33 +8,33 @@ module Update
 
         prepended do
           argument :iteration_widget, ::Types::WorkItems::Widgets::IterationInputType,
-                   required: false,
-                   description: 'Input for iteration widget.'
+            required: false,
+            description: 'Input for iteration widget.'
 
           argument :weight_widget, ::Types::WorkItems::Widgets::WeightInputType,
-                   required: false,
-                   description: 'Input for weight widget.'
+            required: false,
+            description: 'Input for weight widget.'
 
           argument :progress_widget, ::Types::WorkItems::Widgets::ProgressInputType,
-                   required: false,
-                   description: 'Input for progress widget.'
+            required: false,
+            description: 'Input for progress widget.'
 
           argument :status_widget, ::Types::WorkItems::Widgets::StatusInputType,
-                   required: false,
-                   description: 'Input for status widget.'
+            required: false,
+            description: 'Input for status widget.'
 
           argument :health_status_widget, ::Types::WorkItems::Widgets::HealthStatusInputType,
-                   required: false,
-                   description: 'Input for health status widget.'
+            required: false,
+            description: 'Input for health status widget.'
 
           argument :color_widget, ::Types::WorkItems::Widgets::ColorInputType,
-                   required: false,
-                   description: 'Input for color widget.'
+            required: false,
+            description: 'Input for color widget.'
 
           argument :rolledup_dates_widget, ::Types::WorkItems::Widgets::RolledupDatesInputType,
-                   required: false,
-                   description: 'Input for rolledup dates widget.',
-                   alpha: { milestone: '16.9' }
+            required: false,
+            description: 'Input for rolledup dates widget.',
+            alpha: { milestone: '16.9' }
         end
       end
     end

ee/app/graphql/ee/resolvers/issues/base_parent_resolver.rb

@@ -9,9 +9,9 @@ module BaseParentResolver
 
         prepended do
           argument :health_status, ::Types::HealthStatusEnum,
-                   required: false,
-                   deprecated: { reason: 'Use `healthStatusFilter`', milestone: '15.4' },
-                   description: 'Health status of the issue.'
+            required: false,
+            deprecated: { reason: 'Use `healthStatusFilter`', milestone: '15.4' },
+            description: 'Health status of the issue.'
         end
       end
     end

ee/app/graphql/ee/resolvers/issues/base_resolver.rb

@@ -9,35 +9,35 @@ module BaseResolver
 
         prepended do
           argument :epic_id, GraphQL::Types::String,
-                   required: false,
-                   description: 'ID of an epic associated with the issues, "none" and "any" values are supported.'
+            required: false,
+            description: 'ID of an epic associated with the issues, "none" and "any" values are supported.'
           argument :epic_wildcard_id, ::Types::EpicWildcardIdEnum,
-                   required: false,
-                   description: 'Filter by epic ID wildcard. Incompatible with epicId.'
+            required: false,
+            description: 'Filter by epic ID wildcard. Incompatible with epicId.'
           argument :include_subepics, GraphQL::Types::Boolean,
-                   required: false,
-                   description: 'Whether to include subepics when filtering issues by epicId.'
+            required: false,
+            description: 'Whether to include subepics when filtering issues by epicId.'
           argument :iteration_id, [::GraphQL::Types::ID, { null: true }],
-                  required: false,
-                  description: 'List of iteration Global IDs applied to the issue.'
+            required: false,
+            description: 'List of iteration Global IDs applied to the issue.'
           argument :iteration_title, GraphQL::Types::String,
-                  required: false,
-                  description: 'Filter by iteration title.'
+            required: false,
+            description: 'Filter by iteration title.'
           argument :iteration_wildcard_id, ::Types::IterationWildcardIdEnum,
-                   required: false,
-                   description: 'Filter by iteration ID wildcard.'
+            required: false,
+            description: 'Filter by iteration ID wildcard.'
           argument :iteration_cadence_id, [::Types::GlobalIDType[::Iterations::Cadence]],
-                   required: false,
-                   description: 'Filter by a list of iteration cadence IDs.'
+            required: false,
+            description: 'Filter by a list of iteration cadence IDs.'
           argument :weight, GraphQL::Types::String,
-                   required: false,
-                   description: 'Weight applied to the issue, "none" and "any" values are supported.'
+            required: false,
+            description: 'Weight applied to the issue, "none" and "any" values are supported.'
           argument :weight_wildcard_id, ::Types::WeightWildcardIdEnum,
-                   required: false,
-                   description: 'Filter by weight ID wildcard. Incompatible with weight.'
+            required: false,
+            description: 'Filter by weight ID wildcard. Incompatible with weight.'
           argument :health_status_filter, ::Types::HealthStatusFilterEnum,
-                   required: false,
-                   description: 'Health status of the issue, "none" and "any" values are supported.'
+            required: false,
+            description: 'Health status of the issue, "none" and "any" values are supported.'
 
           validates mutually_exclusive: [:weight, :weight_wildcard_id]
           validates mutually_exclusive: [:epic_id, :epic_wildcard_id]

ee/app/graphql/ee/resolvers/namespace_projects_resolver.rb

@@ -8,23 +8,23 @@ module NamespaceProjectsResolver
 
       prepended do
         argument :compliance_framework_filters, ::Types::ComplianceManagement::ComplianceFrameworkFilterInputType,
-                 required: false,
-                 description: 'Filters applied when selecting a compliance framework.'
+          required: false,
+          description: 'Filters applied when selecting a compliance framework.'
 
         argument :has_code_coverage, GraphQL::Types::Boolean,
-                 required: false,
-                 default_value: false,
-                 description: 'Returns only the projects which have code coverage.'
+          required: false,
+          default_value: false,
+          description: 'Returns only the projects which have code coverage.'
 
         argument :has_vulnerabilities, GraphQL::Types::Boolean,
-                 required: false,
-                 default_value: false,
-                 description: 'Returns only the projects which have vulnerabilities.'
+          required: false,
+          default_value: false,
+          description: 'Returns only the projects which have vulnerabilities.'
 
         argument :sbom_component_id, ::GraphQL::Types::ID,
-                 required: false,
-                 default_value: nil,
-                 description: 'Return only the projects related to the specified SBOM component.'
+          required: false,
+          default_value: nil,
+          description: 'Return only the projects related to the specified SBOM component.'
       end
 
       private

ee/app/graphql/ee/resolvers/work_items_resolver.rb

@@ -8,12 +8,12 @@ module WorkItemsResolver
 
       prepended do
         argument :status_widget, ::Types::WorkItems::Widgets::StatusFilterInputType,
-                 required: false,
-                 description: 'Input for status widget filter. Ignored if `work_items_mvc_2` is disabled.'
+          required: false,
+          description: 'Input for status widget filter. Ignored if `work_items_mvc_2` is disabled.'
         argument :requirement_legacy_widget, ::Types::WorkItems::Widgets::RequirementLegacyFilterInputType,
-                 required: false,
-                 deprecated: { reason: 'Use work item IID filter instead', milestone: '15.9' },
-                 description: 'Input for legacy requirement widget filter.'
+          required: false,
+          deprecated: { reason: 'Use work item IID filter instead', milestone: '15.9' },
+          description: 'Input for legacy requirement widget filter.'
       end
 
       override :resolve_with_lookahead

ee/app/graphql/ee/types/alert_management/http_integration_type.rb

@@ -8,18 +8,18 @@ module HttpIntegrationType
 
         prepended do
           field :payload_example, ::Types::JsonStringType,
-                null: true,
-                description: 'Example of an alert payload.'
+            null: true,
+            description: 'Example of an alert payload.'
 
           field :payload_attribute_mappings, [::Types::AlertManagement::PayloadAlertMappingFieldType],
-                null: true,
-                description: 'The custom mapping of GitLab alert attributes to fields from the payload_example.',
-                resolver: ::Resolvers::AlertManagement::PayloadAlertMappingFieldResolver
+            null: true,
+            description: 'The custom mapping of GitLab alert attributes to fields from the payload_example.',
+            resolver: ::Resolvers::AlertManagement::PayloadAlertMappingFieldResolver
 
           field :payload_alert_fields, [::Types::AlertManagement::PayloadAlertFieldType],
-                null: true,
-                description: 'Extract alert fields from payload example for custom mapping.',
-                resolver: ::Resolvers::AlertManagement::PersistedPayloadAlertFieldResolver
+            null: true,
+            description: 'Extract alert fields from payload example for custom mapping.',
+            resolver: ::Resolvers::AlertManagement::PersistedPayloadAlertFieldResolver
         end
       end
     end

ee/app/graphql/ee/types/boards/board_issue_input_base_type.rb

@@ -8,20 +8,20 @@ module BoardIssueInputBaseType
 
         prepended do
           argument :epic_id, ::Types::GlobalIDType[::Epic],
-                   required: false,
-                   description: 'Filter by epic ID. Incompatible with epicWildcardId.'
+            required: false,
+            description: 'Filter by epic ID. Incompatible with epicWildcardId.'
 
           argument :iteration_title, GraphQL::Types::String,
-                   required: false,
-                   description: 'Filter by iteration title.'
+            required: false,
+            description: 'Filter by iteration title.'
 
           argument :weight, GraphQL::Types::String,
-                   required: false,
-                   description: 'Filter by weight.'
+            required: false,
+            description: 'Filter by weight.'
 
           argument :iteration_id, [::Types::GlobalIDType[::Iteration]],
-                   required: false,
-                   description: 'Filter by a list of iteration IDs. Incompatible with iterationWildcardId.'
+            required: false,
+            description: 'Filter by a list of iteration IDs. Incompatible with iterationWildcardId.'
         end
       end
     end

ee/app/graphql/ee/types/boards/board_issue_input_type.rb

@@ -9,25 +9,25 @@ module BoardIssueInputType
         prepended do
           # NONE/ANY epic filter can not be negated
           argument :epic_wildcard_id, ::Types::EpicWildcardIdEnum,
-                   required: false,
-                   description: 'Filter by epic ID wildcard. Incompatible with epicId.'
+            required: false,
+            description: 'Filter by epic ID wildcard. Incompatible with epicId.'
 
           argument :iteration_wildcard_id, ::Types::IterationWildcardIdEnum,
-                   required: false,
-                   description: 'Filter by iteration ID wildcard.'
+            required: false,
+            description: 'Filter by iteration ID wildcard.'
 
           argument :iteration_cadence_id, [::Types::GlobalIDType[::Iterations::Cadence]],
-                   required: false,
-                   description: 'Filter by a list of iteration cadence IDs.'
+            required: false,
+            description: 'Filter by a list of iteration cadence IDs.'
 
           argument :weight_wildcard_id, ::Types::WeightWildcardIdEnum,
-                   required: false,
-                   description: 'Filter by weight ID wildcard. Incompatible with weight.'
+            required: false,
+            description: 'Filter by weight ID wildcard. Incompatible with weight.'
 
           argument :health_status_filter, ::Types::HealthStatusFilterEnum,
-                    required: false,
-                    as: :health_status,
-                    description: 'Health status of the issue, "none" and "any" values are supported.'
+            required: false,
+            as: :health_status,
+            description: 'Health status of the issue, "none" and "any" values are supported.'
         end
       end
     end

ee/app/graphql/ee/types/boards/negated_board_issue_input_type.rb

@@ -8,11 +8,11 @@ module NegatedBoardIssueInputType
 
         prepended do
           argument :iteration_wildcard_id, ::Types::NegatedIterationWildcardIdEnum,
-                   required: false,
-                   description: 'Filter by iteration ID wildcard.'
+            required: false,
+            description: 'Filter by iteration ID wildcard.'
           argument :health_status_filter, ::Types::HealthStatusEnum,
-                   required: false,
-                   description: 'Health status not applied to the issue.
+            required: false,
+            description: 'Health status not applied to the issue.
                     Includes issues where health status is not set.'
         end
       end

ee/app/graphql/ee/types/branch_protections/base_access_level_type.rb

@@ -8,14 +8,14 @@ module BaseAccessLevelType
 
         prepended do
           field :user,
-                ::Types::AccessLevels::UserType,
-                null: true,
-                description: 'User associated with this access level.'
+            ::Types::AccessLevels::UserType,
+            null: true,
+            description: 'User associated with this access level.'
 
           field :group,
-                ::Types::AccessLevels::GroupType,
-                null: true,
-                description: 'Group associated with this access level.'
+            ::Types::AccessLevels::GroupType,
+            null: true,
+            description: 'Group associated with this access level.'
         end
       end
     end

ee/app/graphql/ee/types/branch_rules/branch_protection_type.rb

@@ -8,14 +8,14 @@ module BranchProtectionType
 
         prepended do
           field :unprotect_access_levels,
-                type: ::Types::BranchProtections::UnprotectAccessLevelType.connection_type,
-                null: true,
-                description: 'Details about who can unprotect this branch.'
+            type: ::Types::BranchProtections::UnprotectAccessLevelType.connection_type,
+            null: true,
+            description: 'Details about who can unprotect this branch.'
 
           field :code_owner_approval_required,
-                type: GraphQL::Types::Boolean,
-                null: false,
-                description: 'Enforce code owner approvals before allowing a merge.'
+            type: GraphQL::Types::Boolean,
+            null: false,
+            description: 'Enforce code owner approvals before allowing a merge.'
         end
       end
     end

ee/app/graphql/ee/types/ci/runner_countable_connection_type.rb

@@ -8,9 +8,9 @@ module RunnerCountableConnectionType
 
         prepended do
           field :jobs_statistics, ::Types::Ci::JobsStatisticsType,
-                null: true,
-                resolver: ::Resolvers::Ci::RunnersJobsStatisticsResolver,
-                extras: [:lookahead]
+            null: true,
+            resolver: ::Resolvers::Ci::RunnersJobsStatisticsResolver,
+            extras: [:lookahead]
         end
       end
     end

ee/app/graphql/ee/types/deployment_type.rb

@@ -7,21 +7,21 @@ module DeploymentType
 
       prepended do
         field :pending_approval_count,
-               GraphQL::Types::Int,
-               description: 'Number of pending unified approvals on the deployment.' do
+          GraphQL::Types::Int,
+          description: 'Number of pending unified approvals on the deployment.' do
           extension ::Gitlab::Graphql::Limit::FieldCallCount, limit: 1
         end
 
         field :approval_summary,
-              ::Types::Deployments::ApprovalSummaryType,
-              description: 'Approval summary of the deployment.' \
-                           'This field can only be resolved for one deployment in any single request.' do
+          ::Types::Deployments::ApprovalSummaryType,
+          description: 'Approval summary of the deployment.' \
+                       'This field can only be resolved for one deployment in any single request.' do
           extension ::Gitlab::Graphql::Limit::FieldCallCount, limit: 1
         end
 
         field :approvals,
-              type: [::Types::Deployments::ApprovalType],
-              description: 'Current approvals of the deployment.' do
+          type: [::Types::Deployments::ApprovalType],
+          description: 'Current approvals of the deployment.' do
           extension ::Gitlab::Graphql::Limit::FieldCallCount, limit: 1
         end
       end

ee/app/graphql/ee/types/environment_type.rb

@@ -7,9 +7,9 @@ module EnvironmentType
 
       prepended do
         field :protected_environments,
-              ::Types::ProtectedEnvironmentType.connection_type,
-              description: 'Protected Environments for the environment.',
-              resolver: ::Resolvers::Environments::ProtectedEnvironmentsResolver
+          ::Types::ProtectedEnvironmentType.connection_type,
+          description: 'Protected Environments for the environment.',
+          resolver: ::Resolvers::Environments::ProtectedEnvironmentsResolver
       end
     end
   end