Skip to content
Snippets Groups Projects
Commit 036891df authored by Vijay Hawoldar's avatar Vijay Hawoldar
Browse files

Removes reset_seat_banner_callouts feature flag

The reset_seat_banner_callouts FF was used to derisk a conditional logic
change. Now the FF has been rolled out, we can remove it.

Changelog: removed
EE: true
parent 6c12f5b0
1 merge request!164340Removes reset_seat_banner_callouts feature flag
......@@ -150,8 +150,6 @@ def enqueue_cleanup_group_protected_branch_rules(member)
def reset_seats_usage_callouts(member)
namespace = member.source.root_ancestor
return unless ::Feature.enabled?(:reset_seat_banner_callouts, namespace)
member.run_after_commit_or_now do
::Groups::ResetSeatCalloutsWorker.perform_async(namespace)
end
......
---
name: reset_seat_banner_callouts
feature_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/480846
introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/163774
rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/480895
milestone: '17.4'
group: group::utilization
type: gitlab_com_derisk
default_enabled: false
......@@ -125,28 +125,10 @@
expect(project_2_participant.reload.is_removed).to eq(true)
end
context 'when reset_seat_banner_callouts is enabled for the group' do
before do
stub_feature_flags(reset_seat_banner_callouts: group)
end
it 'calls the reset callout service for the namespace' do
expect(::Groups::ResetSeatCalloutsWorker).to receive(:perform_async).with(group)
it 'calls the reset callout service for the namespace' do
expect(::Groups::ResetSeatCalloutsWorker).to receive(:perform_async).with(group)
destroy_service.execute(member)
end
end
context 'when reset_seat_banner_callouts is disabled for the group' do
before do
stub_feature_flags(reset_seat_banner_callouts: false)
end
it 'does not call the reset callout service for the namespace' do
expect(::Groups::ResetSeatCalloutsWorker).not_to receive(:perform_async).with(group)
destroy_service.execute(member)
end
destroy_service.execute(member)
end
end
......@@ -162,28 +144,10 @@
expect(project_2_participant.reload.is_removed).to eq(false)
end
context 'when reset_seat_banner_callouts is enabled for the group' do
before do
stub_feature_flags(reset_seat_banner_callouts: group)
end
it 'calls the reset callout service for the namespace' do
expect(::Groups::ResetSeatCalloutsWorker).to receive(:perform_async).with(group)
destroy_service.execute(project_member)
end
end
it 'calls the reset callout service for the namespace' do
expect(::Groups::ResetSeatCalloutsWorker).to receive(:perform_async).with(group)
context 'when reset_seat_banner_callouts is disabled for the group' do
before do
stub_feature_flags(reset_seat_banner_callouts: false)
end
it 'does not call the reset callout service for the namespace' do
expect(::Groups::ResetSeatCalloutsWorker).not_to receive(:perform_async).with(group)
destroy_service.execute(project_member)
end
destroy_service.execute(project_member)
end
end
end
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment