-
This refactors ServicePing::SubmitService to remove Service Ping payload generation logic from it and let it have one responsibility - sending the payload and handling the response from version-gitlab-com. Since !85503, payload generation is instead handled in GitlabServicePingWorker, where it's then passed as an argument to SubmitService. Relevant specs, docs and rake tasks are updated accordingly. Some specs had to be removed in their entirety, since they tested generating the payload rather than sending it.
46d78149
Code owners
:
Zack Cuddy, Florie Guibert, David O'Regan, Ezekiel Kigbo, Phil Hughes, Martin Wortschack, Natalia Tepluhina, Mike Greiling, Tim Zallmann, Kushal Pandya, Paul Slaughter, Enrique Alcántara, Illya Klymov, Andrew Fontaine, Denys Mishunov, Jose Ivan Vargas, Olena Horal-Koretska, Miguel Rincon, Savas Vedova, Jacques Erasmus, Simon Knox, Scott Hampton, Peter Hegman, Mark Florian, Jiaan Louw, Robert Hunt, Nicolò Maria Mezzopera, Vitaly Slobodin, Brandon Labuschagne, Michael Lunøe, Frédéric Caplette, David Pisek, Alexander Turinske, Jannik Lehmann, Anna Vovchenko, Michele Bursi, Marin Jankovski, Amy Phillips, Alessio Caiazza, John Skarbek, Ahmad Tolba, Graeme Gillies, Jenny Kim, Matt Field, Mayra Cabrera, Reuben Pereira, GitLab Release Tools Bot, James Lopez, Peter Leitzen, Huzaifa Iftikhar, Sean McGivern, Douglas Barbosa Alexandre, Stan Hu, Grzegorz Bizon, Rémy Coutable, Kamil Trzciński, Bob Van Landuyt, Alexandru Croitor, Jan Provaznik, Thong Kuah, Heinrich Lee Yu, Imre Farkas, charlie ablett, Dylan Griffith, Albert Salim, Shinya Maeda, Jarka Košanová, James Fargher, Sincheol (David) Kim, Igor Drozdov, Mikołaj Wawrzyniak, Matthias Käppler, Vitali Tatarintev, Patrick Bajao, Fabio Pitino, Lin Jen-Shin, David Fernandez, Mark Chao, Kerri Miller, Alper Akgun, Terri Chu, Gabriel Mazetto, Aleksei Lipniagov, Sean Arnold, Etienne Baqué, Arturo Herrero, Alex Kalderimis, Nikola Milojevic, Dmitry Gruzd, Doug Stull, Alex Pooley, Robert May, Vasilii Iakliushin, Andy Soiron, Tetiana Chupryna, Allison Browne, Pavel Shutsin, Furkan Ayhan, Marius Bobin, Marc Shaw, Ethan Urie, Michael Kozono, Ash McKenzie, Luke Duncalfe, Max Woolf, George Koltsov, Allen Cook, Steve Abrams, Tiger Watson, Krasimir Angelov, Alex Ives, João Alexandre Cunha, Adam Hegyi, Simon Tomlinson, Diogo Frazão, Chloe Liu, Tiffany Rea, Ramya Authappan, Anastasia McDonald, Andrejs Cunskis, Dan Davison, Mark Lapierre, Sanad Liaquat, Hordur Freyr Yngvason, Cheryl Li, Marcel Amirault, Laura Montemayor, Jacob Vosmaer, and Kyle Wiebers