Skip to content
  • Leonardo da Rosa's avatar
    36c74f4e
    Change data consistency for workers maintained by source_code_manageme · 36c74f4e
    Leonardo da Rosa authored
    ## What does this MR
    
    It updates workers data consistency from `:always` to `:sticky` for workers maintained by `source_code_management`.
    
    To reduce resource saturation on the primary node, all workers should be changed to `sticky`, at minimum.
    
    Since jobs are now enqueued along with the current database LSN, the replica (for `:sticky` or `:delayed`)
    is guaranteed to be caught up to that point, or the job will be retried, or use the primary. Consider updating
    the worker(s) to `delayed`, if it's applicable.
    
    You can read more about the Sidekiq Workers `data_consistency` in
    https://docs.gitlab.com/ee/development/sidekiq/worker_attributes.html#job-data-consistency-strategies.
    
    Currently, the `gitlab-housekeeper` is not always capable of updating all references, so you must check the diff
    and pipeline failures to confirm if there are any issues.
    
    This change was generated by
    [gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper)
    using the Keeps::UpdateWorkersDataConsistency keep.
    
    To provide feedback on your experience with `gitlab-housekeeper` please create an issue with the
    label ~"GitLab Housekeeper" and consider pinging the author of this keep.
    
    Changelog: other
    
    # Conflicts:
    #	.rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml
    
    # Conflicts:
    #	.rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml
    36c74f4e
    Change data consistency for workers maintained by source_code_manageme
    Leonardo da Rosa authored
    ## What does this MR
    
    It updates workers data consistency from `:always` to `:sticky` for workers maintained by `source_code_management`.
    
    To reduce resource saturation on the primary node, all workers should be changed to `sticky`, at minimum.
    
    Since jobs are now enqueued along with the current database LSN, the replica (for `:sticky` or `:delayed`)
    is guaranteed to be caught up to that point, or the job will be retried, or use the primary. Consider updating
    the worker(s) to `delayed`, if it's applicable.
    
    You can read more about the Sidekiq Workers `data_consistency` in
    https://docs.gitlab.com/ee/development/sidekiq/worker_attributes.html#job-data-consistency-strategies.
    
    Currently, the `gitlab-housekeeper` is not always capable of updating all references, so you must check the diff
    and pipeline failures to confirm if there are any issues.
    
    This change was generated by
    [gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper)
    using the Keeps::UpdateWorkersDataConsistency keep.
    
    To provide feedback on your experience with `gitlab-housekeeper` please create an issue with the
    label ~"GitLab Housekeeper" and consider pinging the author of this keep.
    
    Changelog: other
    
    # Conflicts:
    #	.rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml
    
    # Conflicts:
    #	.rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml
Loading