Skip to content
Snippets Groups Projects
Select Git revision
  • set-default-auto-stop-setting
  • enikon-master-patch-58ce
  • sh-fix-rack-attack-rate-limiting-runner-api
  • master default protected
  • djb-master-patch-45736
  • 513686-validate-saml-sso
  • 521322-show-skipped-rows-in-csv-email
  • tor/telemetry/assign-reviewer-other-ways
  • 514661-document-glas-enabled-by-default
  • 497757-action-in-snowplow-tracking-should-not-have-spaces-in-them
  • ff/cleanup-authentication_logs_migration_for_allowlist
  • 521041/aslota-rename-custom-status-widget-to-status-widget
  • rails-next protected
  • ruby-next protected
  • 521939-follow-up-from-add-support-for-epic-quick-action-on-work-items
  • 457854-clean-up-admin-push-rules-policies
  • release-tools/update-gitaly
  • jcunha/fix-memory-on-boot
  • sentence-case-container-registry
  • 513160-fetch-version-project
  • v17.7.6-ee protected
  • v17.8.4-ee protected
  • v17.9.1-ee protected
  • v17.8.3-ee protected
  • v17.7.5-ee protected
  • v17.9.0-ee protected
  • v17.9.0-rc42-ee protected
  • v17.6.5-ee protected
  • v17.7.4-ee protected
  • v17.8.2-ee protected
  • v17.6.4-ee protected
  • v17.7.3-ee protected
  • v17.8.1-ee protected
  • v17.8.0-ee protected
  • v17.7.2-ee protected
  • v17.8.0-rc42-ee protected
  • v17.5.5-ee protected
  • v17.6.3-ee protected
  • v17.7.1-ee protected
  • v17.7.0-ee protected
40 results

update.rb

  • Andrew Smith's avatar
    d28523e2
    Correct validate epic_color_highlight FF in Epic mutations · d28523e2
    Andrew Smith authored and Matthias Käppler's avatar Matthias Käppler committed 
    
The validation for the Epic `color` attribute was attempting to check
the feature flag status without passing in the group object to check the
feature flag against causing the attribute to always be removed unless
the feature flag was enabled globally.

The removal of the `color` attribute also happened at the wrong time.
The `color` attribute should be removed if the flag isn't enabled before
checking `args.empty?`.

Signed-off-by: default avatarAndrew Smith <espadav8@gmail.com>
    d28523e2
    History
    Correct validate epic_color_highlight FF in Epic mutations
    Andrew Smith authored and Matthias Käppler's avatar Matthias Käppler committed 
    
The validation for the Epic `color` attribute was attempting to check
the feature flag status without passing in the group object to check the
feature flag against causing the attribute to always be removed unless
the feature flag was enabled globally.

The removal of the `color` attribute also happened at the wrong time.
The `color` attribute should be removed if the flag isn't enabled before
checking `args.empty?`.

Signed-off-by: default avatarAndrew Smith <espadav8@gmail.com>
Code owners
Assign users and groups as approvers for specific file changes. Learn more.