Skip to content
Snippets Groups Projects
Select Git revision
  • 482499-cronjob-to-evaluate-compliance-controls
  • dg-fix-issues
  • pl-rubocop-internal-affairs
  • 470699-requirement-entries
  • master default protected
  • rails-next protected
  • ruby-next protected
  • 470699-present-data
  • 470699-model-validations
  • 523685-add-severity-override-to-pipeline-page
  • ysiev-vulnerability-namespace-statistics-update-service
  • master-i18n
  • selhorn-ci-paths
  • qa-knapsack-master-report-update
  • quarantine-flaky-tests-ee-spec-services-app_sec-fuzzing-coverage-corpuses-create_service_spec-rb-44
  • quarantine-flaky-tests-ee-spec-models-incident_management-issuable_escalation_status_spec-rb-48
  • quarantine-flaky-tests-spec-lib-gitlab-error_tracking-error_repository-open_api_strategy_spec-rb-215
  • quarantine-flaky-tests-ee-spec-db-seeds-data_seeder-bulk_data_spec-rb-6
  • quarantine-flaky-tests-ee-spec-requests-api-invitations_spec-rb-412
  • quarantine-flaky-tests-ee-spec-features-work_items-work_items_list_filters_spec-rb-36
  • v17.7.6-ee protected
  • v17.8.4-ee protected
  • v17.9.1-ee protected
  • v17.8.3-ee protected
  • v17.7.5-ee protected
  • v17.9.0-ee protected
  • v17.9.0-rc42-ee protected
  • v17.6.5-ee protected
  • v17.7.4-ee protected
  • v17.8.2-ee protected
  • v17.6.4-ee protected
  • v17.7.3-ee protected
  • v17.8.1-ee protected
  • v17.8.0-ee protected
  • v17.7.2-ee protected
  • v17.8.0-rc42-ee protected
  • v17.5.5-ee protected
  • v17.6.3-ee protected
  • v17.7.1-ee protected
  • v17.7.0-ee protected
40 results

usage_data_spec.rb

  • Piotr Skorupa's avatar
    a51f4e64
    Add HLLRedisCounter errors to redis_usage_counter · a51f4e64
    Piotr Skorupa authored 
    There are instances (e.g. in Gitlab::UsageData) of passing
HLLRedisCounter to the block in #redis_usage_data and it's errors
wouldn't be rescued to return fallback value. This would potentially
result in failing the entire Usage Ping generation.

This prevents that and hardens the method. All HLLRedisCounter custom
exceptions are rescued, since EventError is their superclass.

See !54600
    a51f4e64
    History
    Add HLLRedisCounter errors to redis_usage_counter
    Piotr Skorupa authored 
    There are instances (e.g. in Gitlab::UsageData) of passing
HLLRedisCounter to the block in #redis_usage_data and it's errors
wouldn't be rescued to return fallback value. This would potentially
result in failing the entire Usage Ping generation.

This prevents that and hardens the method. All HLLRedisCounter custom
exceptions are rescued, since EventError is their superclass.

See !54600
Code owners
Assign users and groups as approvers for specific file changes. Learn more.