Skip to content
Snippets Groups Projects
Select Git revision
  • saf-query-organization-cluster-agents
  • sf/feature/validate-against-local-for-com-515773
  • sh-ci-runners-db-constraint-migration
  • trizzi-master-patch-0b71
  • eb-rails-openbao-auth
  • bm/update-ruby-default
  • 522011-backfill-finish-onboarding-saml
  • z_painter/nuget-docs-update
  • master default protected
  • rails-next protected
  • ruby-next protected
  • 498253-move-the-blob-page-edit-button-from-the-blob-header-to-the-title-area
  • irinabron/521403-custom-stats-autovacuum-settings
  • jmd/testing
  • 461796-remove-redundant-constants-file
  • 521971-variables-inputs-banner
  • 523701-vue3-migration-add_on_eligible_user_list_spec
  • ms/custom-status/status-quick-action
  • cngo-fix-foss-new-issue-look
  • 514373-provide-helper-methods-for-defining-sharding-keys-for-models
  • v17.7.6-ee protected
  • v17.8.4-ee protected
  • v17.9.1-ee protected
  • v17.8.3-ee protected
  • v17.7.5-ee protected
  • v17.9.0-ee protected
  • v17.9.0-rc42-ee protected
  • v17.6.5-ee protected
  • v17.7.4-ee protected
  • v17.8.2-ee protected
  • v17.6.4-ee protected
  • v17.7.3-ee protected
  • v17.8.1-ee protected
  • v17.8.0-ee protected
  • v17.7.2-ee protected
  • v17.8.0-rc42-ee protected
  • v17.5.5-ee protected
  • v17.6.3-ee protected
  • v17.7.1-ee protected
  • v17.7.0-ee protected
40 results

create_pipeline_service.rb

  • Hordur Freyr Yngvason's avatar
    82cf739d
    Fix incorrect branch access check · 82cf739d
    Hordur Freyr Yngvason authored 
    This fixes a bug during merge request pipeline creation permission
checks, in which a ref path or a commit SHA was passed where a branch
name was expected. As a result, the check almost always returned
true (and would almost never hit the intended protection check), causing
the entire pipeline creation to fail.

Changelog: fixed
    Verified
    82cf739d
    History
    Fix incorrect branch access check
    Hordur Freyr Yngvason authored 
    This fixes a bug during merge request pipeline creation permission
checks, in which a ref path or a commit SHA was passed where a branch
name was expected. As a result, the check almost always returned
true (and would almost never hit the intended protection check), causing
the entire pipeline creation to fail.

Changelog: fixed
Code owners
Assign users and groups as approvers for specific file changes. Learn more.