.haml-lint.yml

1 year ago

Add new cop Gitlab/Rails/SafeFormat · 99e2f6fe

Peter Leitzen authored 1 year ago

Enforce `safe_format` for externalized strings with interpolations and
`.html_safe`.

  # bad
  _('string %{open}foo%{close}').html_safe % { open: '<b>'.html_safe, close: '</b>'.html_safe }
  format(_('string %{open}foo%{close}').html_safe, open: '<b>'.html_safe, close: '</b>'.html_safe)

  # good
  safe_format(_('string %{open}foo%{close}'), tag_pair(tag.b, :open, :close)
  # also good no `html_safe`
  format(_('string %{var} number'), var: var)

Verified

99e2f6fe

History

Add new cop Gitlab/Rails/SafeFormat

Peter Leitzen authored 1 year ago

Enforce `safe_format` for externalized strings with interpolations and
`.html_safe`.

  # bad
  _('string %{open}foo%{close}').html_safe % { open: '<b>'.html_safe, close: '</b>'.html_safe }
  format(_('string %{open}foo%{close}').html_safe, open: '<b>'.html_safe, close: '</b>'.html_safe)

  # good
  safe_format(_('string %{open}foo%{close}'), tag_pair(tag.b, :open, :close)
  # also good no `html_safe`
  format(_('string %{var} number'), var: var)

Code owners

Assign users and groups as approvers for specific file changes. Learn more.