Skip to content
Snippets Groups Projects
Select Git revision
  • backfill-desired-sharding-key-large-table-push_event_payloads
  • 16653_add_vulns_api_from_stat_adjustments_branch
  • backfill-desired-sharding-key-small-table-scan_result_policies
  • master default protected
  • rails-next protected
  • ruby-next protected
  • backfill-multiple-desired-sharding-key-small-table-snippet_statistics
  • sharding-key-backfill-keeps
  • backfill-desired-sharding-key-small-table-incident_management_pending_issue_escalations
  • issue_509317
  • eduardosanz/update-codeowners
  • document-new-golang-runbook
  • 505041-add-parent-param-groups-resolver
  • axil-docs-redirects-skip_indexmd
  • 514146-add-sharding-key-for-redirect_routes
  • qa-knapsack-master-report-update
  • brodock/unified-backup-use-rake-directly
  • 515975-project-tool-coverage-indicator
  • 515035-add-ability-to-manage-admin-custom-roles
  • 448868-mr-badge-count
  • v17.7.6-ee protected
  • v17.8.4-ee protected
  • v17.9.1-ee protected
  • v17.8.3-ee protected
  • v17.7.5-ee protected
  • v17.9.0-ee protected
  • v17.9.0-rc42-ee protected
  • v17.6.5-ee protected
  • v17.7.4-ee protected
  • v17.8.2-ee protected
  • v17.6.4-ee protected
  • v17.7.3-ee protected
  • v17.8.1-ee protected
  • v17.8.0-ee protected
  • v17.7.2-ee protected
  • v17.8.0-rc42-ee protected
  • v17.5.5-ee protected
  • v17.6.3-ee protected
  • v17.7.1-ee protected
  • v17.7.0-ee protected
40 results

forbid_sidekiq_in_transactions.rb

  • Stan Hu's avatar
    8decab7a
    Disable Sidekiq worker open transaction check in JS specs · 8decab7a
    Stan Hu authored
    When transactional tests are enabled, Rails ensures that all threads
    use the same connection for accessing the database. However this may
    cause a false positive with the Sidekiq worker open transaction
    check because:
    
    1. A browser may have multiple requests in-flight.
    2. A transaction may start in the middle of another request. For example,
    an update to a merge request column initiates a transaction via SAVEPOINT.
    
    To avoid false positives, disable this check for JavaScript feature
    specs run. The alternative is to use the deletion strategy, but that
    would significantly slow tests.
    
    Relates to #478601
    Verified
    8decab7a
    History
    Disable Sidekiq worker open transaction check in JS specs
    Stan Hu authored
    When transactional tests are enabled, Rails ensures that all threads
    use the same connection for accessing the database. However this may
    cause a false positive with the Sidekiq worker open transaction
    check because:
    
    1. A browser may have multiple requests in-flight.
    2. A transaction may start in the middle of another request. For example,
    an update to a merge request column initiates a transaction via SAVEPOINT.
    
    To avoid false positives, disable this check for JavaScript feature
    specs run. The alternative is to use the deletion strategy, but that
    would significantly slow tests.
    
    Relates to #478601
Code owners
Assign users and groups as approvers for specific file changes. Learn more.