Select Git revision
forbid_sidekiq_in_transactions.rb
-
Stan Hu authored
When transactional tests are enabled, Rails ensures that all threads use the same connection for accessing the database. However this may cause a false positive with the Sidekiq worker open transaction check because: 1. A browser may have multiple requests in-flight. 2. A transaction may start in the middle of another request. For example, an update to a merge request column initiates a transaction via SAVEPOINT. To avoid false positives, disable this check for JavaScript feature specs run. The alternative is to use the deletion strategy, but that would significantly slow tests. Relates to #478601
Stan Hu authoredWhen transactional tests are enabled, Rails ensures that all threads use the same connection for accessing the database. However this may cause a false positive with the Sidekiq worker open transaction check because: 1. A browser may have multiple requests in-flight. 2. A transaction may start in the middle of another request. For example, an update to a merge request column initiates a transaction via SAVEPOINT. To avoid false positives, disable this check for JavaScript feature specs run. The alternative is to use the deletion strategy, but that would significantly slow tests. Relates to #478601
Code owners
Assign users and groups as approvers for specific file changes. Learn more.