keys.rb

2 years ago

Fix deploy keys breaking protected branch dropdown in FIPS mode · 6c2adbb0

Stan Hu authored 2 years ago and

Ezekiel Kigbo committed 2 years ago

In FIPS mode, if a deploy key were present, clicking on the "Allowed
to push" dropdown would fail with a "Failed to load groups, users and
deploy keys" message. This occurred because the JavaScript attempted
to use the `fingerprint` attribute of the key.  However, on a FIPS
system, the MD5 fingerprint is not available, and the `null` value
breaks the dropdown.

To fix this, we use the `fingerprint_sha256` attribute instead. This
commit also puts the SHA256 fingerprint first in the HTML views to
avoid confusion.

Relates to #364562

Changelog: fixed

6c2adbb0

History

Fix deploy keys breaking protected branch dropdown in FIPS mode

Stan Hu authored 2 years ago and

Ezekiel Kigbo committed 2 years ago

In FIPS mode, if a deploy key were present, clicking on the "Allowed
to push" dropdown would fail with a "Failed to load groups, users and
deploy keys" message. This occurred because the JavaScript attempted
to use the `fingerprint` attribute of the key.  However, on a FIPS
system, the MD5 fingerprint is not available, and the `null` value
breaks the dropdown.

To fix this, we use the `fingerprint_sha256` attribute instead. This
commit also puts the SHA256 fingerprint first in the HTML views to
avoid confusion.

Relates to #364562

Changelog: fixed

Code owners

Assign users and groups as approvers for specific file changes. Learn more.