Select Git revision
send_file_upload.rb
-
Stan Hu authored
This is a follow-up merge request to !98010, which enabled job artifacts to be served by Google Cloud CDN for specific API endpoints. This extends this functionality to artifact downloads from the Web UI via the `Download` artifact button. This functionality is behind the `use_cdn_with_job_artifacts_ui_downloads` feature flag. This feature should not only make artifacts downloads faster for users, but it also helps reduce network egress bandwidth costs. Since UI downloads can have `response-content-disposition` and `response-content-type` query parameters, we also need to modify the Cloud CDN implementation to allow passing of query parameters to Google Cloud Storage. Note that Cloud CDN requires that the `Expires`, `KeyName`, and `Signature` query parameters appear at the end of the URL, or the request will fail with a 403 error. Relates to #378473 Changelog: added
Stan Hu authoredThis is a follow-up merge request to !98010, which enabled job artifacts to be served by Google Cloud CDN for specific API endpoints. This extends this functionality to artifact downloads from the Web UI via the `Download` artifact button. This functionality is behind the `use_cdn_with_job_artifacts_ui_downloads` feature flag. This feature should not only make artifacts downloads faster for users, but it also helps reduce network egress bandwidth costs. Since UI downloads can have `response-content-disposition` and `response-content-type` query parameters, we also need to modify the Cloud CDN implementation to allow passing of query parameters to Google Cloud Storage. Note that Cloud CDN requires that the `Expires`, `KeyName`, and `Signature` query parameters appear at the end of the URL, or the request will fail with a 403 error. Relates to #378473 Changelog: added
Code owners
Assign users and groups as approvers for specific file changes. Learn more.