Skip to content
Snippets Groups Projects
Select Git revision
  • axil-raketasks-admin
  • add-learn-more-link-disable-pat-for-enterprise-users
  • 521595-extract-migration-removes-field-shared-examples
  • 521595-fix-rubocop-migration-backfill-helper
  • 520781-only-fetch-custom-field-select-options-when-opening-dropdown
  • master default protected
  • 474369-fe-add-source-filtering-to-build-jobs
  • rodrigo/reduce-direct-transfer-logs
  • rd-create-remediate-page
  • 498396/aslota-fetch-allowed-statuses-from-widget-definitions
  • bs-default-role-copy-fix
  • rd-create-triage-page
  • overdue-finalize-background-migration--delete-orphaned-partitioned-ci-runner-machine-records
  • overdue-finalize-background-migration--backfill-ci-build-trace-metadata-project-id
  • overdue-finalize-background-migration--backfill-ci-secure-file-states-project-id
  • rlehmann1-kr-policies
  • overdue-finalize-background-migration--backfill-ci-job-artifact-states-project-id
  • overdue-finalize-background-migration--backfill-ci-builds-runner-session-project-id
  • overdue-finalize-background-migration--backfill-ml-candidate-metrics-project-id
  • overdue-finalize-background-migration--make-security-policy-bots-private
  • v17.7.6-ee protected
  • v17.8.4-ee protected
  • v17.9.1-ee protected
  • v17.8.3-ee protected
  • v17.7.5-ee protected
  • v17.9.0-ee protected
  • v17.9.0-rc42-ee protected
  • v17.6.5-ee protected
  • v17.7.4-ee protected
  • v17.8.2-ee protected
  • v17.6.4-ee protected
  • v17.7.3-ee protected
  • v17.8.1-ee protected
  • v17.8.0-ee protected
  • v17.7.2-ee protected
  • v17.8.0-rc42-ee protected
  • v17.5.5-ee protected
  • v17.6.3-ee protected
  • v17.7.1-ee protected
  • v17.7.0-ee protected
40 results

send_file_upload.rb

  • Stan Hu's avatar
    587a5956
    Support Google Cloud CDN for Web UI artifacts downloads · 587a5956
    Stan Hu authored
    This is a follow-up merge request to
    !98010, which
    enabled job artifacts to be served by Google Cloud CDN for specific
    API endpoints. This extends this functionality to artifact downloads
    from the Web UI via the `Download` artifact button.
    
    This functionality is behind the
    `use_cdn_with_job_artifacts_ui_downloads` feature flag. This feature
    should not only make artifacts downloads faster for users, but it also
    helps reduce network egress bandwidth costs.
    
    Since UI downloads can have `response-content-disposition` and
    `response-content-type` query parameters, we also need to modify the
    Cloud CDN implementation to allow passing of query parameters to
    Google Cloud Storage. Note that Cloud CDN requires that the `Expires`,
    `KeyName`, and `Signature` query parameters appear at the end of the
    URL, or the request will fail with a 403 error.
    
    Relates to #378473
    
    Changelog: added
    Verified
    587a5956
    History
    Support Google Cloud CDN for Web UI artifacts downloads
    Stan Hu authored
    This is a follow-up merge request to
    !98010, which
    enabled job artifacts to be served by Google Cloud CDN for specific
    API endpoints. This extends this functionality to artifact downloads
    from the Web UI via the `Download` artifact button.
    
    This functionality is behind the
    `use_cdn_with_job_artifacts_ui_downloads` feature flag. This feature
    should not only make artifacts downloads faster for users, but it also
    helps reduce network egress bandwidth costs.
    
    Since UI downloads can have `response-content-disposition` and
    `response-content-type` query parameters, we also need to modify the
    Cloud CDN implementation to allow passing of query parameters to
    Google Cloud Storage. Note that Cloud CDN requires that the `Expires`,
    `KeyName`, and `Signature` query parameters appear at the end of the
    URL, or the request will fail with a 403 error.
    
    Relates to #378473
    
    Changelog: added
Code owners
Assign users and groups as approvers for specific file changes. Learn more.