Skip to content
Snippets Groups Projects
Select Git revision
20 results

navbar_spec.rb

Blame
  • Lukas Eipert's avatar
    71cb5b8c
    Introduce no_super_sidebar trait in specs · 71cb5b8c
    Lukas Eipert authored and Andrew Fontaine's avatar Andrew Fontaine committed
    We are planning to make the super sidebar navigation the default
    navigation. Unfortunately we currently rely on the _old_ navigation
    behavior in more than 150 spec files. Currently the _old_ navigation is
    used in all specs. The plan is to:
    
    1. Introduce a user specific trait (this commit) and move from a global
       "old"-nav switch to a per-test switch.
    2. Remove the global feature flag toggle
       (!126175)
    3. Fix all tests to work with the new nav:
       #420121
    4. Remove the trait.
    
    This commit additionally adds the trait to a few specs in order to show
    that it doesn't break anything:
     - a few navigation related specs (`navbar_spec.rb`)
     - a few fixtures which otherwise break jest specs
     - a few shared examples and related specs
    71cb5b8c
    History
    Introduce no_super_sidebar trait in specs
    Lukas Eipert authored and Andrew Fontaine's avatar Andrew Fontaine committed
    We are planning to make the super sidebar navigation the default
    navigation. Unfortunately we currently rely on the _old_ navigation
    behavior in more than 150 spec files. Currently the _old_ navigation is
    used in all specs. The plan is to:
    
    1. Introduce a user specific trait (this commit) and move from a global
       "old"-nav switch to a per-test switch.
    2. Remove the global feature flag toggle
       (!126175)
    3. Fix all tests to work with the new nav:
       #420121
    4. Remove the trait.
    
    This commit additionally adds the trait to a few specs in order to show
    that it doesn't break anything:
     - a few navigation related specs (`navbar_spec.rb`)
     - a few fixtures which otherwise break jest specs
     - a few shared examples and related specs
Code owners
Assign users and groups as approvers for specific file changes. Learn more.