Skip to content
Snippets Groups Projects
Select Git revision
  • minac_515500_implement_vulnerability_archive_export
  • master default protected
  • hsutor-master-patch-b655
  • cvs_spec_update_pipeline_status
  • charlieeekroon/515827-display-on-hover
  • zoekt-speed-up-scheduling-events
  • tbulva-visible-label-missing-clean
  • pedropombeiro/fix-typo-in-docs
  • dlrussel/policy-scope-fix
  • sf/feature/validate-against-local-for-com-515773
  • 520831-remove-redundant-code
  • julianthome/vulnerability-comparison
  • 182748-documentation
  • fa-create_project_namespace_traversal_paths_table
  • rails-next protected
  • ruby-next protected
  • aalakkad-migrate-usage-quotas-seats-to-apollo-replace-watcher
  • axil-custom-roles
  • led/update-projects-approaching-limit-logic
  • 511014-admin-page-for-targeted-messages-basic-upload
  • v17.7.6-ee protected
  • v17.8.4-ee protected
  • v17.9.1-ee protected
  • v17.8.3-ee protected
  • v17.7.5-ee protected
  • v17.9.0-ee protected
  • v17.9.0-rc42-ee protected
  • v17.6.5-ee protected
  • v17.7.4-ee protected
  • v17.8.2-ee protected
  • v17.6.4-ee protected
  • v17.7.3-ee protected
  • v17.8.1-ee protected
  • v17.8.0-ee protected
  • v17.7.2-ee protected
  • v17.8.0-rc42-ee protected
  • v17.5.5-ee protected
  • v17.6.3-ee protected
  • v17.7.1-ee protected
  • v17.7.0-ee protected
40 results

sh-fix-overwrite-import-export-check.yml

  • Stan Hu's avatar
    8e53ce74
    Fix overwrite check in GitLab import/export · 8e53ce74
    Stan Hu authored
    In gitlab-foss!17883, we
    added a feature that would allow a project export to be uploaded and
    imported successfully before deleting the old copy of the project.
    
    This overwrite feature would always check whether the user had owner
    privileges in the group of the project. If the user only had maintainer
    privileges or less--even if an overwrite was not happening--the
    import/export would fail with an empty `Projects::ImportService::Error`.
    
    To fix this, we make two changes:
    
    1. Only do the permission check if we actually need to overwrite
    the project.
    2. If the permission check fails, raise an exception with details.
    8e53ce74
    History
    Fix overwrite check in GitLab import/export
    Stan Hu authored
    In gitlab-foss!17883, we
    added a feature that would allow a project export to be uploaded and
    imported successfully before deleting the old copy of the project.
    
    This overwrite feature would always check whether the user had owner
    privileges in the group of the project. If the user only had maintainer
    privileges or less--even if an overwrite was not happening--the
    import/export would fail with an empty `Projects::ImportService::Error`.
    
    To fix this, we make two changes:
    
    1. Only do the permission check if we actually need to overwrite
    the project.
    2. If the permission check fails, raise an exception with details.
Code owners
Assign users and groups as approvers for specific file changes. Learn more.