Skip to content
Snippets Groups Projects
Select Git revision
  • master-i18n
  • adjust_admin_display_duo_addon
  • ci-cd-a11y-label-fixes
  • slashmanov/rapid-diffs-instrument-diffs-list-loading
  • master default protected
  • docs-faleksic-needs-artifacts-keyword
  • 508173-follow-up-from-resolve-upstream-pipeline-fails-when-child-trigger-pipeline-passes-trigger
  • 514146-add-trigger-sharding-key-redirect-routes
  • 513704-add-new-min-max-values-to-scheduled-pep-policy-schema
  • 498066-convert-redis-counts-for-diffscounter
  • fix/autocomplete-scoped-search-options
  • jmc-dq-settings-sync
  • 493768-add-merge_request_user_mentions-fk
  • ag/480230-bso-use-cap-error-message
  • 523422-bug-vulnerbaility-statistics-total-not-updated
  • 513686-validate-saml-sso
  • 521110-limit-date-inheritance-to-epics-in-work-item-creation
  • hly-move-custom-fields-graphql-fields
  • andrey-missing-cache-report-jobs
  • add-not-null-constraint-sharding-key-packages_dependency_links
  • v17.7.6-ee protected
  • v17.8.4-ee protected
  • v17.9.1-ee protected
  • v17.8.3-ee protected
  • v17.7.5-ee protected
  • v17.9.0-ee protected
  • v17.9.0-rc42-ee protected
  • v17.6.5-ee protected
  • v17.7.4-ee protected
  • v17.8.2-ee protected
  • v17.6.4-ee protected
  • v17.7.3-ee protected
  • v17.8.1-ee protected
  • v17.8.0-ee protected
  • v17.7.2-ee protected
  • v17.8.0-rc42-ee protected
  • v17.5.5-ee protected
  • v17.6.3-ee protected
  • v17.7.1-ee protected
  • v17.7.0-ee protected
40 results

audit_event_service_spec.rb

  • Yorick Peterse's avatar
    bc197247
    Move read_only/read_write back to Gitlab::Database · bc197247
    Yorick Peterse authored
    These methods were scoped to a connection in
    !65262. A
    discussion after the merge request was merged revealed these methods
    aren't tied to a specific connection, and as such better belong in
    Gitlab::Database.
    
    I briefly considered moving them to the Gitlab module instead, as the
    methods don't actually run any database queries. Unfortunately, this
    isn't possible as this module is loaded too early to prepend it with an
    EE module.
    Verified
    bc197247
    History
    Move read_only/read_write back to Gitlab::Database
    Yorick Peterse authored
    These methods were scoped to a connection in
    !65262. A
    discussion after the merge request was merged revealed these methods
    aren't tied to a specific connection, and as such better belong in
    Gitlab::Database.
    
    I briefly considered moving them to the Gitlab module instead, as the
    methods don't actually run any database queries. Unfortunately, this
    isn't possible as this module is loaded too early to prepend it with an
    EE module.
Code owners
Assign users and groups as approvers for specific file changes. Learn more.