make staticcheck fails on master (+ stable branches?)
Consider:
$ go get -u honnef.co/go/tools/cmd/staticcheck
$ make staticcheck
### govendor-sync
/home/lupine/.gvm/pkgsets/go1.11/global/bin/govendor
### Verify: staticcheck
/home/lupine/.gvm/pkgsets/go1.11/global/bin/staticcheck
../gdk-ce/gitlab-workhorse/src/gitlab.com/gitlab-org/gitlab-workhorse/_build/src/gitlab.com/gitlab-org/gitlab-workhorse/internal/gitaly/gitaly.go:25:6: type connectionsCache is unused (U1000)
Makefile:142: recipe for target 'staticcheck' failed
make: *** [staticcheck] Error 1
We need to fix this on master, and also ensure we're still green on every supported stable branch:
-
8-5-stable
(11.10) -
8-3-stable
(11.9, 11.8) -
8-0-stable
(11.7)
Edited by Nick Thomas