Skip to content

Use of a Broken or Risky Cryptographic Algorithm

Detects imports of crypto/sha1 since they are considered vulnerable.

Go's official documentation also warns against the usage of SHA1.

Most common alternative for the insecure algorithm:

Use SHA512 instead of SHA1 Although, we recommend doing some initial research before using any encryption/hashing algorithm to determine which is best for your use case.

Refer to https://en.wikipedia.org/wiki/SHA-1#Attacks to understand the vulnerability in detail.

Cryptographic algorithms are the methods by which data is scrambled to prevent observation or influence by unauthorized actors. Insecure cryptography can be exploited to expose sensitive information, modify data in unexpected ways, spoof identities of other users or devices, or other impacts.

It is very difficult to produce a secure algorithm, and even high-profile algorithms by accomplished cryptographic experts have been broken. Well-known techniques exist to break or weaken various kinds of cryptography. Accordingly, there are a small number of well-understood and heavily studied algorithms that should be used by most products. Using a non-standard or known-insecure algorithm is dangerous because a determined adversary may be able to break the algorithm and compromise whatever data has been protected.

Since the state of cryptography advances so rapidly, it is common for an algorithm to be considered "unsafe" even if it was once thought to be strong. This can happen when new attacks are discovered, or if computing power increases so much that the cryptographic algorithm no longer provides the amount of protection that was originally thought.

For a number of reasons, this weakness is even more challenging to manage with hardware deployment of cryptographic algorithms as opposed to software implementation. First, if a flaw is discovered with hardware-implemented cryptography, the flaw cannot be fixed in most cases without a recall of the product, because hardware is not easily replaceable like software. Second, because the hardware product is expected to work for years, the adversary's computing power will only increase over time.

Problematic code: https://github.com/gitlabhq/blob/master/workhorse/internal/upload/destination/multi_hash.go#L5-L5 - SHA1

Reference: https://owasp.org/Top10/A02_2021-Cryptographic_Failures/