Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • See what's new at GitLab
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
gitlab-workhorse
gitlab-workhorse
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 73
    • Issues 73
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 18
    • Merge Requests 18
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issues
    • Repository
    • Value Stream
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GitLab.org
  • gitlab-workhorsegitlab-workhorse
  • Issues
  • #226

Closed
Open
Opened Jun 26, 2019 by Alessio Caiazza@nolith🔴
  • Report abuse
  • New issue
Report abuse New issue

Allow object storage acceleration from JSON encoded body

This issue originates from gitlab-org/gitlab-ce#63097

Our NPM package doesn't have workhorse upload acceleration, and members of the wider community are contributing new features based on that https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9012#note_179607151

The reason being is that we don't have a body hijacking handler for JSON encoded requests.

What happens with these kinds of uploads is that a file is provided in base64 encoding inside the JSON body.

This is how we handle NPM Object Storage uploading on rails side.

Proposal

We should implement a handler that can hijack JSON encoded body, stripping base64 encoded files and replacing them with the usual metadata workhorse generates on upload acceleration.

/cc @marin @dzaporozhets

Linked issues

  • Discussion
  • Designs
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
4
Labels
devopspackage grouppackage performance teamDelivery
Assign labels
  • View project labels
Reference: gitlab-org/gitlab-workhorse#226