[Bug] 404's triggered on extension install
MR: Fix open vsx resource url template (gitlab!183071 - merged)
Description
Identified in this thread:
4. Why does the
.../extensionURL's fail?So! This seems like a separate issue, but still relevant, and still important to fix... From Open VSX API docs, there's 2 ways we can request individual blobs from an extension:
/vscode/asset/{namespaceName}/{extensionName}/{version}/{assetType}/**(What we currently use)/vscode/unpkg/{namespaceName}/{extensionName}/{version}/**(What we used to use).We moved from the
vscode/unpkgroute tovscode/assetin this MR because:
- It seemed like other consumers of VSCode used this route. Now that I'm looking again, I think most use the
vscode/unpkgroute (although some use thevscode/assetone).- The
vscodevim.vimextension started randomly not working :|But! It looks like the
vscode/unpkgroute is working now and this is the one that allows us to request a directory which VSCode tries to do with/extension(see relevant code that tried to look forpackage.nls.jsonwithin the directory).
Acceptance criteria
-
Installing an extension doesn't throw a 404 request.
Implementation plan
Let's update main GitLab project to use https://open-vsx.org/vscode/unpkg/{publisher}/{name}/{version}/{path} which supports requesting directories.
