[Bug] Click "Reload required" after uninstalling extension blows up
Description
Noticed while testing Add Extensions Marketplace in Web IDE (gitlab!151352 - merged) locally:
- With extensions marketplace enabled, install an extension that requires reload on uninstall (like
vscodevim
) - View the extension and click Uninstall
- Click Reload required
- Web IDE blows up
😞
Investigation
- This might have something to do with the
workspaceProvider.open
we provide https://gitlab.com/gitlab-org/gitlab-web-ide/-/blob/51f9e91f890752596e7a3ef51f436fea07885eff/packages/vscode-bootstrap/src/start.ts#L297 - Maybe there's something we can do with our
onWillShutdown
handling here https://gitlab.com/gitlab-org/gitlab-web-ide/-/blob/51f9e91f890752596e7a3ef51f436fea07885eff/packages/vscode-bootstrap/src/start.ts#L184