You need to sign in or sign up before continuing.
Update VSCode submodule to 1.94.0
MR: Update VSCode to 1.94.0 (!118 - merged)
Spike MR: Update VSCode to 1.94.0 (!118 - merged)
Description
In version 1.94.0
, VSCode introduced some architectural changes that affects the build process:
- Migrated from
yarn
tonpm
. - Migrated their module loading system from
AMD
toESM
. - Part of this initiative includes changes to how some files are bundled in the gulp tasks:
loader.js
is included in the bundle in thevscode-web
source path instead ofvscode/out-vscode-web-min
, which we rely on in ourbuild-and-bundle-web.sh
script. We rely on this file as it contains the AMD-related methods required to mount VSCode in the Web IDE.
Acceptance criteria
-
Update the VSCode submodule tag to 1.94.0
and resolve conflicts when applying the dev patches for both Web IDE and Workspaces. -
Update VSCode related scripts to use npm
instead ofyarn
. -
In the build-and-bundle-web.sh
script:-
Update source path to be vscode-web
instead ofvscode/out-vscode-web-min
in thebuild-and-bundle-web.sh
script.
-
-
Remove DISABLE_V8_COMPILE_CACHE=1
flag. Since the project has migrated tonpm
, we no longer need this flag. More context in original issue: Follow-up: Remove DISABLE_V8_COMPILE_CACHE flag... (#51 - closed) -
Create a new release
Edited by Cindy Halim