Commit c850efd7 authored by Andrew Fontaine's avatar Andrew Fontaine Committed by Michael Angelo Rivera
Browse files

fix: do not escape external webview URI

parent 9e1d7d6f

src/common/webview/get_ls_webview_content.ts

+4 −1
Original line number Diff line number Diff line
@@ -6,7 +6,10 @@ import osxKeyboardEventScript from './templates/osx_keyboard_event_fix.template. 


export const getWebviewContent = async (url: URL, title: string) => {

  const externalUri = await vscode.env.asExternalUri(vscode.Uri.parse(url.toString()));

  const externalUrl = new URL(externalUri.toString());

  // toString takes a parameter to skip percentage-encoding the URI, we want to use this

  // to ensure any query params are left as is.

  // https://github.com/microsoft/vscode/issues/248416#issuecomment-2863512926

  const externalUrl = new URL(externalUri.toString(true));



  const safeTitle = escapeHtml(title);

  const safeOrigin = escapeHtml(externalUrl.origin);