feat: show all accounts in VS Code accounts view

Description

This MR changes the authentication provider so that we can provide VS Code with all extension accounts (in all instances, both OAuth and PAT).

This MR also adds reactivity, so that when you sign out, the account gets removed from the list.

before	after
Only OAuth token is shown for gitlab.com	All GitLab accounts are shown

Also, the sign-out command did not update the list of accounts. I.e. signing out didn't remove the account from the list of accounts

before	after
sign-out-not-working	sign-out-working

In the same way, authenticating using OAuth didn't add the account to the list. (The list was only updated once the extension started.)

Related Issues

Resolves #1381 (closed)

How has this been tested?

1. Add OAuht and PAT accounts to the extension (using the Gitlab: Authenticate command)
2. see that both accounts are in the account menu (see screencasts and screenshots above
3. validate that when you sign out from the account, it disappears from the list

What CHANGELOG entry will this MR create?

• fix: Bug fix fixes - a user-facing issue in production - included in changelog
• feature: New feature - a user-facing change which adds functionality - included in changelog
• BREAKING CHANGE: (fix or feature that would cause existing functionality to change) - should bump major version, mentioned in the changelog
• None - other non-user-facing changes

src/desktop/accounts/oauth/gitlab_authentication_provider.test.ts

-import { createOAuthAccount } from '../../test_utils/entities';
+import { createOAuthAccount, createTokenAccount } from '../../test_utils/entities';
 import { AccountService } from '../account_service';
 import { createExtensionContext } from '../../../common/test_utils/entities';
 import { GitLabAuthenticationProvider } from './gitlab_authentication_provider';
 
-jest.mock('../../commands/openers');
-jest.mock('../../gitlab/gitlab_service');
-jest.useFakeTimers();
-
 describe('GitLabAuthenticationProvider', () => {
   let accountService: AccountService;
+  const oauthAccount = createOAuthAccount('https://test.com', 1, 'oauth-1');
+  const patAccount = createTokenAccount('https://test.com', 2, 'pat-1');
 
   beforeEach(async () => {
     accountService = new AccountService();
@@ -17,13 +15,62 @@ describe('GitLabAuthenticationProvider', () => {
 
   describe('getting existing session', () => {
     it('gets a session if there is existing oauth account', async () => {
-      await accountService.addAccount(createOAuthAccount());
+      await accountService.addAccount(oauthAccount);
+      await accountService.addAccount(patAccount);
+      const provider = new GitLabAuthenticationProvider(accountService);
+
+      const [oauthSession, patSession] = await provider.getSessions(['api']);
+
+      expect(oauthSession.accessToken).toBe(oauthAccount.token);
+      expect(oauthSession.account.id).toBe(oauthAccount.id);
+      expect(oauthSession.account.label).toBe('user1 (https://test.com)');
+      expect(patSession.accessToken).toBe(patAccount.token);
+    });
+  });
+
+  describe('notifying of changes', () => {
+    it('notifies about added accounts', async () => {
+      const listener = jest.fn();
       const provider = new GitLabAuthenticationProvider(accountService);
+      provider.onDidChangeSessions(listener);
 
-      const sessions = await provider.getSessions(['api']);
+      await accountService.addAccount(oauthAccount);
 
-      expect(sessions).toHaveLength(1);
-      expect(sessions[0].accessToken).toBe(createOAuthAccount().token);
+      expect(listener).toHaveBeenCalledWith({
+        added: [expect.objectContaining({ accessToken: oauthAccount.token })],
+        removed: [],
+      });
     });
+
+    it('notifies about removed accounts', async () => {
+      const listener = jest.fn();
+      const provider = new GitLabAuthenticationProvider(accountService);
+      await accountService.addAccount(oauthAccount);
+      provider.onDidChangeSessions(listener);
+
+      await accountService.removeAccount(oauthAccount.id);
+
+      expect(listener).toHaveBeenCalledWith({
+        removed: [expect.objectContaining({ accessToken: oauthAccount.token })],
+        added: [],
+      });
+    });
+  });
+
+  it('createSession throws an error', async () => {
+    const provider = new GitLabAuthenticationProvider(accountService);
+
+    await expect(provider.createSession()).rejects.toThrow(
+      /Creating `gitlab.com` sessions .* is not supported/,
+    );
+  });
+
+  it('removeSession deletes account', async () => {
+    await accountService.addAccount(oauthAccount);
+    const provider = new GitLabAuthenticationProvider(accountService);
+
+    await provider.removeSession(oauthAccount.id);
+
+    expect(accountService.getAllAccounts()).toHaveLength(0);
   });
 });