feat: show all accounts in VS Code accounts view

Description

This MR changes the authentication provider so that we can provide VS Code with all extension accounts (in all instances, both OAuth and PAT).

This MR also adds reactivity, so that when you sign out, the account gets removed from the list.

before	after
Only OAuth token is shown for gitlab.com	All GitLab accounts are shown

Also, the sign-out command did not update the list of accounts. I.e. signing out didn't remove the account from the list of accounts

before	after
sign-out-not-working	sign-out-working

In the same way, authenticating using OAuth didn't add the account to the list. (The list was only updated once the extension started.)

Related Issues

Resolves #1381 (closed)

How has this been tested?

1. Add OAuht and PAT accounts to the extension (using the Gitlab: Authenticate command)
2. see that both accounts are in the account menu (see screencasts and screenshots above
3. validate that when you sign out from the account, it disappears from the list

What CHANGELOG entry will this MR create?

• fix: Bug fix fixes - a user-facing issue in production - included in changelog
• feature: New feature - a user-facing change which adds functionality - included in changelog
• BREAKING CHANGE: (fix or feature that would cause existing functionality to change) - should bump major version, mentioned in the changelog
• None - other non-user-facing changes

added Category:Editor Extensions Editor ExtensionsVS Code devopscreate groupeditor extensions sectiondev typefeature labels

assigned to @viktomas

Reviewer roulette

Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.

Reviewer	Maintainer
@jannik_lehmann (UTC+1, same timezone as author)	@juhee.lee (UTC-8, 9 hours behind author)

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

mentioned in merge request !2214 (closed)

changed the description

changed the description

marked this merge request as ready

@ohoral can I please ask you to review this MR?

requested review from @ohoral

approved this merge request

changed milestone to %17.9

added workflowin review label

added 2 commits

• 7650bb06 - refactor: use dash to separate username and instance
• 64c732ac - refactor: use lodash differenceBy

Compare with previous version

mentioned in issue #1816

resolved all threads

enabled automatic add to merge train when checks pass

resolved all threads

aborted automatic add to merge train because the source branch was updated. Learn more.

added 9 commits

• 64c732ac...66b6410b - 6 commits from branch main
• d7ae6490 - feat: show all accounts in VS Code accounts view
• dc5897c6 - refactor: use dash to separate username and instance
• 7093485a - refactor: use lodash differenceBy

Compare with previous version

enabled automatic add to merge train when checks pass

started a merge train

merged

mentioned in commit 3aa8c648

This MR is included in version 5.39.0

The release is available on:

• GitLab release
• v5.39.0

Your semantic-release bot