ci: adjust rule order for scheduled e2e runs
Description
Follow up from !1580 (merged)
Adjusts the rule order so that 2 jobs don't run in e2e scheduled pipelines against main
. They were matching on
- if: '$CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH'
when: always
when run against main
so they never got to
- <<: *if-scheduled-e2e
when: never
Related Issues
Resolves #[issue_number]
How has this been tested?
Screenshots (if appropriate)
Types of changes
-
Bug fix (non-breaking change which fixes an issue) -
New feature (non-breaking change which adds functionality) -
Breaking change (fix or feature that would cause existing functionality to change) -
Documentation -
Chore (Related to CI or Packaging to platforms) -
Test gap
Merge request reports
Activity
changed milestone to %17.1
assigned to @dchevalier2
added sectiondev label
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Reviewer Maintainer @ohoral
(UTC+3, 7 hours ahead of
@dchevalier2
)@aturinske
(UTC-7, 3 hours behind
@dchevalier2
)Generated by
Danger- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@dchevalier2 - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
added maintenancepipelines typemaintenance labels
@pslaughter can you review this small fix since you are familiar with the changes please?
requested review from @pslaughter
Thanks for the quick fix here @dchevalier2! I wish it was easier to test these pipeline executions out (it probably is and I'm just missing something)
Changes LGTM
Approving and starting merge...
mentioned in commit 27902d40