ci: remove extra jobs in scheduled e2e run

Description

There are jobs that do not need to be run in the scheduled daily e2e pipeline.

Only test-e2e needs to be run here. This MR removes check-ci-variables and check-icons. I'm not sure if the other 3 can be removed from these runs.

How has this been tested?

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation
• Chore (Related to CI or Packaging to platforms)
• Test gap

.gitlab-ci.yml

@@ -9,6 +9,12 @@ include:
   - project: 'gitlab-org/quality/pipeline-common'
     file: '/ci/danger-review.yml' # danger-review job below
 
+# region: conditions ----------------------------------
+.if-scheduled-e2e: &if-scheduled-e2e
+  if: '$CI_PIPELINE_SOURCE == "schedule" && $RUN_E2E == "true"'
+
+# region: jobs ----------------------------------------
+
 # why: Similar to https://gitlab.com/gitlab-org/cli/-/merge_requests/1352 to avoid
 # upstream breaking changes
 danger-review:
@@ -83,7 +89,7 @@ check-ci-variables:
       changes:
         - 'src/ci/ci_variables.json'
         - 'scripts/update_ci_variables.js'
-    - if: '$CI_PIPELINE_SOURCE == "schedule" && $RUN_E2E == "true"'
+    - <<: *if-scheduled-e2e
       when: never
 
 check-icons:
@@ -98,7 +104,7 @@ check-icons:
     - if: '$CI_PIPELINE_SOURCE == "merge_request_event"'
       changes:
         - 'src/assets/icons/*'
-    - if: '$CI_PIPELINE_SOURCE == "schedule" && $RUN_E2E == "true"'
+    - <<: *if-scheduled-e2e
       when: never
 
 test-unit: