[FE] - Feature flag rollout for Security Findings
To complete the &10407 (closed) feature, we need to remove the feature flag.
Context:
- We cannot set a default feature flag state (ie. Default on)
- The other option is release with flag logic, but require the user to take manual steps to enable the feature
Decision
-
Spoke with @connorgilbert and the decision was to remove the flag logic effectively releasing the feature to all users.
-
If we discover bugs post release, users can revert extension version, or we can push a fix.
-
If there is a gitlab version mismatch, we don't make the network request if the gitlab instance is less than
16.1.0
(When the API endpoints were introduced) -
If we are in CE edition, or the user lacks the correct user role in the project, we fail silently and show "no scan results"
Edited by Fernando Cardenas