Self-managed accounts silently fail after password change due to secret storage error
Checklist
-
I'm using the latest version of the extension (see the latest version in the right column of this page) - Extension version: 3.47.2
-
I'm using the latest VS Code version (find the latest version here) - VS Code version: 1.69.1
-
I'm using a supported version of GitLab (see README for the supported version) - GitLab version: 14.10.4-ee
Summary
Executing the "GitLab: Add Account to VS Code" command stops working after password change. Pre-existing accounts silently blocking all access.
Steps to reproduce
- Configure GitLab Workflow with a self-managed URL
- Change the current user's system password
- Reboot & try to use GitLab Workflow extension
- No error is reported, but no GitLab information is available in the extension
- Try to Add Account
- Enter self-managed URL and press enter
- Enter access token and press enter
- No error is reported, but no GitLab information is available
- Execute "GitLab: Remove Account from VS Code"
- Repeat from step 5, but this time everything works
What is the current bug behavior?
No indication is given to the user that all their accounts are invalidated by changing their password
What is the expected correct behavior?
If there is an error accessing secret storage, it should be visible to the user. Ideally, changing a password would not disconnect all accounts.
Relevant logs and/or screenshots
[error]: Account for instance https://oxford.awsdev.infor.com and user ben.marty is missing a token in secret storage. Remove the account and add it again.