New Check on adding a token hides error messages.
Checklist
-
I'm using the latest version of the extension (see the latest version in the right column of this page) - Extension version: v3.42.0
-
I'm using the latest VS Code version (find the latest version here) - VS Code version: 1.66.0
-
I'm using a supported version of GitLab (see README for the supported version) - GitLab version: 14.8
Summary
I can't add an access token to the extension.
Steps to reproduce
- Install GitLab Workflow from scratch
- Try to add an access token, either via the menu or the commands.
What is the current bug behavior?
Either nothing happens or an error message is displayed.
What is the expected correct behavior?
Token is added.
Relevant logs and/or screenshots
[error]: {
"userMessage": "Request failed: Can't add GitLab account for https://. Check your instance URL and network connection.",
"errorMessage": "Fetching current user from https:///api/v4/user failed",
"stack": [
"Error: Fetching current user from https:///api/v4/user failed",
"\tat Ns (c:\\Users\\\\.vscode\\extensions\\gitlab.gitlab-workflow-3.42.0\\out\\extension.js:284:444)",
"\tat runMicrotasks ()",
"\tat processTicksAndRejections (node:internal/process/task_queues:96:5)",
"\tat async ma.fetch (c:\\Users\\\\.vscode\\extensions\\gitlab.gitlab-workflow-3.42.0\\out\\extension.js:284:1586)",
"\tat async lv (c:\\Users\\\\.vscode\\extensions\\gitlab.gitlab-workflow-3.42.0\\out\\extension.js:302:21781)",
"\tat async x0 (c:\\Users\\\\.vscode\\extensions\\gitlab.gitlab-workflow-3.42.0\\out\\extension.js:302:22425)",
"\tat async c:\\Users\\\\.vscode\\extensions\\gitlab.gitlab-workflow-3.42.0\\out\\extension.js:336:1540",
"\tat async m._executeContributedCommand (c:\\Users\\\\AppData\\Local\\Programs\\Microsoft VS Code\\resources\\app\\out\\vs\\workbench\\api\\node\\extensionHostProcess.js:85:30752)"
]
}
log
Possible fixes
v3.42.0 seems to have added a check after adding a token. This blocks the real error from being visible. With v3.41.2 I get an error from the company proxy. So the problem seems to be, that the new check doesn't show the root cause. So a user is not enabled to search for a solution.
Edited by Dominik Föhl