Snapshot deadlock with css in CE
We created a dashboard-skeleton
component in gitlab-ui
to be used on dashboard pages when the cards are loading. !191 (merged)
There was custom CSS needed, so it was added to CE and EE https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/25874 https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9197
In order for the CE and EE to be merged, we needed to merge the dashboard-skeleton
MR so that we could use that component. We created a snapshot for the dashboard-skeleton
, but it didn't look like the final product because the CSS in CE wasn't merged yet.
Now when we run the pipeline for CE, we get an error saying that the snapshot has failed because there is different CSS. https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/173490177
In summary, we have a test in gitlab-ui and when we add CSS to GitLab CE it breaks the gitlab-ui test. But in order to update the test in gitlab-ui we first need the CSS in GitLab CE to be merged, otherwise the snapshot test will break in gitlab-ui. We are in a deadlock.
See the slack conversation here: https://gitlab.slack.com/archives/CG3MT4JLW/p1551974487001400