fix(duochat): Don't submit on enter if composing in IME (ef57dece) · Commits · GitLab.org / gitlab-ui · GitLab

Commit ef57dece authored Jun 06, 2024 by Eduardo Bonet

fix(duochat): Don't submit on enter if composing in IME

Some languages (eg Japanese IME) allow users to select an entry based on
the typed letters, which is selected by pressed enter. Duo chat
automatically sends the message without taking this into account,
causing users to send unfinished messages. Taking isComposing into
account prevents this from happening.

See issue #2537 (comment 1938464119)

parent ceec431c

Hide whitespace changes

Inline Side-by-side

Ghost User @ghost1
mentioned in commit f43a86c7
· Jun 07, 2024

mentioned in commit f43a86c7

mentioned in commit f43a86c7b8b667cf69cf39c371bcf120f7fbd3e0

Toggle commit list
GitLab Dependency Bot @gitlab-dependency-update-bot
mentioned in merge request status-page!903
· Jun 07, 2024

mentioned in merge request status-page!903

mentioned in merge request status-page!903

Toggle commit list
GitLab Dependency Bot @gitlab-dependency-update-bot
mentioned in merge request gitlab!155758 (merged)
· Jun 07, 2024

mentioned in merge request gitlab!155758 (merged)

mentioned in merge request gitlab!155758

Toggle commit list
GitLab Dependency Bot @gitlab-dependency-update-bot
mentioned in merge request gitlab!155845 (merged)
· Jun 10, 2024

mentioned in merge request gitlab!155845 (merged)

mentioned in merge request gitlab!155845

Toggle commit list
GitLab Dependency Bot @gitlab-dependency-update-bot
mentioned in merge request gitlab!155946 (closed)
· Jun 11, 2024

mentioned in merge request gitlab!155946 (closed)

mentioned in merge request gitlab!155946

Toggle commit list
GitLab Dependency Bot @gitlab-dependency-update-bot
mentioned in merge request gitlab-org/editor-extensions/gitlab-jetbrains-plugin!570 (merged)
· Jun 13, 2024

mentioned in merge request gitlab-org/editor-extensions/gitlab-jetbrains-plugin!570 (merged)

mentioned in merge request gitlab-org/editor-extensions/gitlab-jetbrains-plugin!570

Toggle commit list
GitLab Dependency Bot @gitlab-dependency-update-bot
mentioned in merge request gitlab-org/gitlab-services/design.gitlab.com!3891 (merged)
· Jun 17, 2024

mentioned in merge request gitlab-org/gitlab-services/design.gitlab.com!3891 (merged)

mentioned in merge request gitlab-org/gitlab-services/design.gitlab.com!3891

Toggle commit list
GitLab Dependency Bot @gitlab-dependency-update-bot
mentioned in merge request gitlab-org/gitlab-services/design.gitlab.com!3892 (merged)
· Jun 17, 2024

mentioned in merge request gitlab-org/gitlab-services/design.gitlab.com!3892 (merged)

mentioned in merge request gitlab-org/gitlab-services/design.gitlab.com!3892

Toggle commit list
GitLab Dependency Bot @gitlab-dependency-update-bot
mentioned in merge request gitlab-org/frontend/playground/accessibility-scanner!39 (merged)
· Jul 01, 2024

mentioned in merge request gitlab-org/frontend/playground/accessibility-scanner!39 (merged)

mentioned in merge request gitlab-org/frontend/playground/accessibility-scanner!39

Toggle commit list
GitLab Dependency Bot @gitlab-dependency-update-bot
mentioned in merge request gitlab-org/frontend/pajamas-adoption-scanner!337 (merged)
· Jul 01, 2024

mentioned in merge request gitlab-org/frontend/pajamas-adoption-scanner!337 (merged)

mentioned in merge request gitlab-org/frontend/pajamas-adoption-scanner!337

Toggle commit list
GitLab Dependency Bot @gitlab-dependency-update-bot
mentioned in merge request gitlab-org/frontend/playground/accessibility-scanner!40 (merged)
· Jul 01, 2024

mentioned in merge request gitlab-org/frontend/playground/accessibility-scanner!40 (merged)

mentioned in merge request gitlab-org/frontend/playground/accessibility-scanner!40

Toggle commit list
GitLab Dependency Bot @gitlab-dependency-update-bot
mentioned in merge request gitlab-org/frontend/pajamas-adoption-scanner!338 (merged)
· Jul 01, 2024

mentioned in merge request gitlab-org/frontend/pajamas-adoption-scanner!338 (merged)

mentioned in merge request gitlab-org/frontend/pajamas-adoption-scanner!338

Toggle commit list
GitLab Dependency Bot @gitlab-dependency-update-bot
mentioned in merge request gitlab-org/frontend/playground/accessibility-scanner!42 (closed)
· Jul 01, 2024

mentioned in merge request gitlab-org/frontend/playground/accessibility-scanner!42 (closed)

mentioned in merge request gitlab-org/frontend/playground/accessibility-scanner!42

Toggle commit list

Please register or to comment