fix(GlFilteredSearch): Improve handling of some falsey values
This allows `false`, `0` and `''` to be handled better as values in options. Previously, an option with one of these values could never get automatically selected when typing their title in a segment. An example where this can be seen is the Confidential token in Roadmaps: https://gitlab.com/gitlab-org/gitlab/-/blob/2dcb4f37a26ffff6b2cebc6b1f55f1294b1b545d/ee/app/assets/javascripts/roadmap/mixins/filtered_search_mixin.js#L179-180. The `null` and `undefined` (and `NaN`) values are still ignored.
Loading
-
mentioned in commit c130578d
-
mentioned in merge request gitlab!116201 (closed)
-
mentioned in merge request gitlab-org/frontend/pajamas-adoption-scanner!127 (merged)
-
mentioned in merge request status-page!747 (merged)
-
mentioned in merge request gitlab-docs!3727 (closed)
-
mentioned in merge request gitlab-org/gitlab-services/design.gitlab.com!3331 (merged)
-
mentioned in merge request gitlab!116736 (merged)
-
mentioned in merge request gitlab!116885 (merged)
-
mentioned in merge request gitlab!117076 (merged)
-
mentioned in merge request gitlab-docs!3751 (merged)
-
🔴 @markrianmentioned in merge request !3598 (merged)
Please register or sign in to comment