fix(GlFilteredSearch): Don't prevent tabbing past component
This is a follow-up to 0798e433 which added support for opening the token suggestion list when tabbing to the input. Unfortunately, that broke tabbing forward past the component. This is because the next focusable element in document order after the input is the first suggestion. The fix therefore is to make it unable to receive focus via the keyboard. This doesn't harm accessbility, since that list was never able to receive focus anyway, since it's removed when the input loses focus. Ideally there'd be a test for this, but Cypress doesn't support sending Tab keypresses: https://github.com/cypress-io/cypress/issues/299.
Loading
-
mentioned in commit 763ab540
-
mentioned in merge request gitlab-org/frontend/pajamas-adoption-scanner!133 (merged)
-
mentioned in merge request status-page!758 (merged)
-
mentioned in merge request gitlab!117429 (merged)
-
mentioned in merge request gitlab-docs!3775 (merged)
-
mentioned in merge request gitlab-org/gitlab-services/design.gitlab.com!3353 (merged)
-
mentioned in merge request gitlab!118512 (merged)
Please register or sign in to comment