feat(Bootstrap): Remove color variable settings in _reboot.scss
All threads resolved!
Compare changes
Files
7
15.85 KiB | W: 800 | H: 600

16.15 KiB | W: 800 | H: 600
In this MR I move the color settings on anchors
from the Bootstrap _reboot
file to typography
and apply design token colors. Additionally I moved the styles for the text-decoration
, to keep it all in one place.
I believe that the following implementation could work as well, is less code, and does not have to use :not()
:
// Setting colors on real anchors with an href,
// but not on placeholder links/named anchors (without href).
a:is([href]) {
@apply gl-text-link gl-no-underline hover:gl-text-link hover:gl-underline;
}
I did not want to create bugs in consuming repositories and decided to stick to a clear refactoring in this MR.
To test this locally, I suggest to go to http://localhost:9001/?path=/docs/base-link--docs and remove the CSS Class gl-link
from the HTML. Then, the typography.scss
styles get activated. Alternatively, the components with the screenshot updates can be verified.
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.
~"component:*"
label(s) if applicable.If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
@gitlab-com/gl-security/appsec
If this MR adds or modifies a component, take a few moments to review the following:
aria-label
for icons that have meaning or perform actions.aria-expanded="false"
to aria-expanded="true"
when an accordion is expanded.Related to #2821
15.85 KiB | W: 800 | H: 600
16.15 KiB | W: 800 | H: 600