Skip to content

Draft: chore: add vscode design token mode

Scott de Jonge requested to merge sdejonge-design-tokens-vscode-mode into main

What does this MR do?

Component styles in DuoChat used by IDE extensions like gitlab-vscode-extension require overrides to use IDE specific values.

Since we have tokenisation of some components, can we leverage a design token mode to add values like var(--vscode-button-foreground) to button.default.primary.foreground.color?

Questions:

  1. Does this scale for all component styles/requirements?
  2. What do we do about utility class usage in DuoChat? e.g. should we update to semantic utility classes like gl-text-subtle to use var(--vscode-disabledForeground) (do we want this anyway?) instead of:
.gl-text-gray-500 {
  color: var(--glDuoChat-foreground-muted);
}

Screenshots or screen recordings

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Merge request reports