feat(css): Add gl-mb-n* util classes
What does this MR do?
Classes are used in gitlab!126197 (merged).
These classes are used for further decreasing margin between UI elements with fixed margins.
Screenshots or screen recordings
Margin between gl-form-group
is decreased in the drawer.
With classes | Without classes |
---|---|
![]() |
![]() |
Integration merge requests
-
GitLab: mr_url -
CustomersDot: mr_url -
Status Page: mr_url
Does this MR meet the acceptance criteria?
This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.
Toggle the acceptance checklist
Conformity
-
Code review guidelines. -
GitLab UI's contributing guidelines. - [-] If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
- [-] If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
- [-] If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
- [-] Added the
~"component:*"
label(s) if applicable.
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] Security reports checked/validated by a reviewer from the AppSec team
Accessibility
If this MR adds or modifies a component, take a few moments to review the following:
-
All actions and functionality can be done with a keyboard. -
Links, buttons, and controls have a visible focus state. -
All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label
for icons that have meaning or perform actions. -
Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false"
toaria-expanded="true"
when an accordion is expanded. -
Color combinations have sufficient contrast.
Merge request reports
Activity
assigned to @mgandres
Minor release (conventional commits)This Merge Request will trigger a minor release of GitLab UI, triggered by commit: 12fd76f3
This will bump the second part of the version number, e.g.
v1.2.3
->v1.3.0
.Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend Phil Hughes (
@iamphill
) (UTC+1, 7 hours behind@mgandres
)Olena HK. (
@ohoral
) (UTC+0, 8 hours behind@mgandres
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@mgandres - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
added devopsmanage groupfoundations labels
added sectiondev label
marked the checklist item Code review guidelines. as completed
marked the checklist item GitLab UI's contributing guidelines. as completed
added featureenhancement typefeature labels
@iamphill Could you review this MR please?
requested review from @iamphill
requested review from @pgascouvaillancourt and removed review request for @iamphill
added 151 commits
-
cfed5fa2...fd5b7ad0 - 150 commits from branch
main
- 12fd76f3 - feat(css): Add gl-mb-n* util classes
-
cfed5fa2...fd5b7ad0 - 150 commits from branch
Apologies for the huge delay @mgandres
I was assigned as the maintainer despite being out of office for a few weeks.This looks good to me. I just scheduled a rebase as this MR is somewhat old now. Let's merge this!
Thanks @pgascouvaillancourt! Honestly this slipped out of my mind and I was OOO as well, so no worries there. I'll create a follow-up MR to add the missing class and cleanup
utilities.scss
.Edited by Mireya Andres
changed milestone to %16.4
enabled automatic add to merge train when the pipeline for f35a7620 succeeds
mentioned in commit ce4404b7
mentioned in merge request gitlab!130420 (merged)
mentioned in merge request gitlab!126197 (merged)